From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: FW: [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device Date: Fri, 14 Sep 2012 14:09:06 +0100 Message-ID: <20120914130904.GB12893@gmail.com> References: <014401cd8165$99960c40$ccc224c0$@se> <50377C0D.2060905@stericsson.com> <20120827163337.GC4339@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id 3824C262639 for ; Fri, 14 Sep 2012 15:09:11 +0200 (CEST) Received: by eeke50 with SMTP id e50so2140343eek.38 for ; Fri, 14 Sep 2012 06:09:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120827163337.GC4339@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: roger.xr.nilsson@stericsson.com, Ola Lilja , "alsa-devel@alsa-project.org" , Linus Walleij , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gTW9uLCBBdWcgMjcsIDIwMTIgYXQgMDk6MzM6MzhBTSAtMDcwMCwgTWFyayBCcm93biB3cm90 ZToKPiBPbiBGcmksIEF1ZyAyNCwgMjAxMiBhdCAwMzowNToxN1BNICswMjAwLCBPbGEgTGlsamEg d3JvdGU6Cj4gCj4gPiBJIGhhdmVuJ3QgZm9sbG93ZWQgZXZlcnl0aGluZyBpbiB0aGlzIGRpc2N1 c3Npb24sIGJ1dCB3aGF0IEkgbWVhbnQgaW4gYW4gZWFybGllcgo+ID4gbWFpbCB3YXMgdGhhdCB1 c2luZyB0aGUgZGV2aWNlIGZvciBwbGF0Zm9ybS1EQUkgKE1TUF9JMlMpIGFsc28KPiA+IGFzIHBs YXRmb3JtIGludCB0aGUgREFJLWxpbmsgc3RydWN0IGlzIG5vdCBhbnl0aGluZyBJIGNhbiBzZWUg Zml0IChhcyBpbiB0aGUKPiA+IHBhdGNoIExlZSBmaXJzdCBzdWJtaXR0ZWQpLgo+IAo+IEknbSBu b3Qgc3VyZSBJIGZ1bGx5IHVuZGVyc3RhbmQgdGhlIGFib3ZlIC0gSSBkaWRuJ3Qgbm90aWNlIGFu eXRoaW5nCj4gd2l0aCB0aGUgZGFpIGxpbmtzIGJ1dCBJIGhhdmUgdG8gc2F5IHRoYXQgSSBjb3Vs ZCd2ZSBsb29rZWQgbW9yZSBjbG9zZWx5Cj4gYXMgSSB3YXMgd2FpdGluZyBmb3IgQVJNIHNpZGUg cmV2aWV3cy4KPiAKPiA+IEkgY2FuIHNlZSBhIGZldyBhY2NlcHRhYmxlIHNvbHV0aW9uczoKPiA+ IDEpIFVzZSBpdCBhcyBpdCBpcyEgKEEgdmlydHVhbCBkZXZpY2UgZm9yIFBDTSBpcyBjcmVhdGVk IGluIGFyY2gvYXJtIGFuZCB0aGUKPiA+IHByb2JlIGlzIGludm9rZWQgZnJvbSB0aGUgbWFjaGlu ZS1kcml2ZXIpLgo+ID4gMikgU2luY2UgdGhlIGFjdHVhbCBwbGF0Zm9ybSBpcyB0aGUgRE1BLWJs b2NrLCBtYXliZSB0aGVyZSBpcyBzb21lIHdheSBvZiBtYWtpbmcKPiA+IHRoZSBkZXZpY2UgIm5v bi12aXJ0dWFsIiBieSBoYXZpbmcgc29tZSBzdWItZGV2aWNlIGluIHRoZSBETUEtZHJpdmVyIHRo YXQgaXMKPiA+IGluc3RlYWQgdHJpZ2dlcmVkIGluIHRoZSBzYW1lIHdheSBhcyBpbiAxKS4KPiAK PiBUaGUgb3B0aW9uIHdlJ3JlIHVzaW5nIGlzIGVzc2VudGlhbGx5IHlvdXIgb3B0aW9uIDIgYnV0 IGRvaW5nIGl0IGZyb20KPiB0aGUgREFJIGRyaXZlciByYXRoZXIgdGhhbiBmcm9tIHRoZSBETUEg ZHJpdmVyIChrZWVwaW5nIHRoaW5ncyBpbiB0aGUKPiBhdWRpbyBzdWJzeXN0ZW0gc2luY2UgaXQn cyBhbiBhdWRpbyBzcGVjaWZpYyBpc3N1ZSkuCgpPbGEgY291bGQgeW91IHBsZWFzZSByZXBseSB0 byB0aGlzLiBXaXRob3V0IHlvdXIgQWNrIHRoaXMgaXMgb3VyIGJpZ2dlc3QKYmxvY2tlci4gVGhl cmUgYXJlIG90aGVyIGF1ZGlvIGRyaXZlcnMgd2hpY2ggZG8gaXQgdGhpcyB3YXkgYWxyZWFkeS4g V2UKYXJlIGFscmVhZHkgZG9pbmcgc29tZXRoaW5nIHlvdSBzdWdnZXN0ZWQsIGp1c3QgaW4gYSBz bGlnaHRseSBkaWZmZXJlbnQKKG1vcmUgY29udGFpbmVkKSB3YXkuCgpQbGVhc2UgcmVzcG9uZC4K CktpbmQgcmVnYXJkcywKTGVlCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVC1Fcmljc3NvbiBMYW5k aW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJN IFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcg bGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9q ZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Fri, 14 Sep 2012 14:09:06 +0100 Subject: FW: [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device In-Reply-To: <20120827163337.GC4339@opensource.wolfsonmicro.com> References: <014401cd8165$99960c40$ccc224c0$@se> <50377C0D.2060905@stericsson.com> <20120827163337.GC4339@opensource.wolfsonmicro.com> Message-ID: <20120914130904.GB12893@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Aug 27, 2012 at 09:33:38AM -0700, Mark Brown wrote: > On Fri, Aug 24, 2012 at 03:05:17PM +0200, Ola Lilja wrote: > > > I haven't followed everything in this discussion, but what I meant in an earlier > > mail was that using the device for platform-DAI (MSP_I2S) also > > as platform int the DAI-link struct is not anything I can see fit (as in the > > patch Lee first submitted). > > I'm not sure I fully understand the above - I didn't notice anything > with the dai links but I have to say that I could've looked more closely > as I was waiting for ARM side reviews. > > > I can see a few acceptable solutions: > > 1) Use it as it is! (A virtual device for PCM is created in arch/arm and the > > probe is invoked from the machine-driver). > > 2) Since the actual platform is the DMA-block, maybe there is some way of making > > the device "non-virtual" by having some sub-device in the DMA-driver that is > > instead triggered in the same way as in 1). > > The option we're using is essentially your option 2 but doing it from > the DAI driver rather than from the DMA driver (keeping things in the > audio subsystem since it's an audio specific issue). Ola could you please reply to this. Without your Ack this is our biggest blocker. There are other audio drivers which do it this way already. We are already doing something you suggested, just in a slightly different (more contained) way. Please respond. Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog