From mboxrd@z Thu Jan 1 00:00:00 1970 From: Serge Hallyn Subject: Re: [PATCH] userns: fix return value on mntns_install() failure Date: Fri, 14 Sep 2012 08:15:04 -0500 Message-ID: <20120914131504.GA29678@amd1> References: <50519B6B.1050902@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <50519B6B.1050902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Zhao Hongjiang Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org List-Id: containers.vger.kernel.org Quoting Zhao Hongjiang (zhaohongjiang37-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org): > From: Zhao Hongjiang > > Change return value from -EINVAL to -EPERM when the permission check fails. > > Signed-off-by: Zhao Hongjiang That also matches what other *_install do. Acked-by: Serge E. Hallyn > --- > fs/namespace.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/namespace.c b/fs/namespace.c > index 72be266..1e79d20 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -2764,7 +2764,7 @@ static int mntns_install(struct nsproxy *nsproxy, void *ns) > > if (!ns_capable(mnt_ns->user_ns, CAP_SYS_ADMIN) || > !nsown_capable(CAP_SYS_CHROOT)) > - return -EINVAL; > + return -EPERM; > > if (fs->users != 1) > return -EINVAL; > -- 1.7.1 > _______________________________________________ > Containers mailing list > Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linuxfoundation.org/mailman/listinfo/containers