From: Andrew Morton <akpm@linux-foundation.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [memcg:since-3.5 93/137] include/linux/rbtree_augmented.h:123: warning: '__rb_erase_color' decla
Date: Fri, 14 Sep 2012 21:13:59 +0000 [thread overview]
Message-ID: <20120914141359.632d464f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120914025922.GD31454@yliu-dev.sh.intel.com>
On Fri, 14 Sep 2012 14:10:04 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> akpm:/usr/src/25> size lib/rbtree_test.o
> text data bss dec hex filename
> 3599 117 5224 8940 22ec lib/rbtree_test.o (before)
> 4176 117 5384 9677 25cd lib/rbtree_test.o (after)
>
> that's crazy!
Although the changelog and Documentation/rbtree.txt do explain the
situation. Nobody ever reads them. This explanation should be in a
big fat comment at the rb_erase_augmented() site, please.
prev parent reply other threads:[~2012-09-14 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 2:59 [memcg:since-3.5 93/137] include/linux/rbtree_augmented.h:123: warning: '__rb_erase_color' declared Fengguang Wu
2012-09-14 21:10 ` [memcg:since-3.5 93/137] include/linux/rbtree_augmented.h:123: warning: '__rb_erase_color' decla Andrew Morton
2012-09-14 21:13 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914141359.632d464f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.