From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC][PATCH 4/4] drm: i915: Atomic pageflip WIP Date: Fri, 14 Sep 2012 18:52:10 +0300 Message-ID: <20120914155210.GH19732@intel.com> References: <1347464827-14187-1-git-send-email-ville.syrjala@linux.intel.com> <1347464827-14187-5-git-send-email-ville.syrjala@linux.intel.com> <84c8a8$5o3vcu@orsmga001.jf.intel.com> <20120914142130.GE19732@intel.com> <84c8a8$5o4ac7@orsmga001.jf.intel.com> <20120914153021.GF19732@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C4B19F5E8 for ; Fri, 14 Sep 2012 08:52:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Sep 14, 2012 at 05:39:30PM +0200, Daniel Vetter wrote: > On Fri, Sep 14, 2012 at 5:30 PM, Ville Syrj=E4l=E4 > wrote: > > intel_pipe_set_base() won't disable the pipe or change the size, > > it'll just flip the primary plane. So that doesn't quite explain > > why the call is there, as opposed to being called just from the > > full modeset path. > = > intel_pipe_set_base is also called in the modeset case, i.e. when we > could potentially change the height of the mode. And if we wait on a > large enough scanline which doesn't exist in the new mode this would > hang. Yes, I know it's called in both cases. But my point is that there doesn't seem to be any reason to call it in the pure set_base case. > The other callsite of finish_fb is from intel_crtc_disable. Yep. There it does make sense to me. -- = Ville Syrj=E4l=E4 Intel OTC