From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 14 Sep 2012 10:12:22 -0700 Subject: [U-Boot] [PATCHv3] ARM: Add Altera SOCFPGA Cyclone5 In-Reply-To: <1347642157-1829-1-git-send-email-dinguyen@altera.com> References: <1347642157-1829-1-git-send-email-dinguyen@altera.com> Message-ID: <20120914171222.GA22028@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Sep 14, 2012 at 11:02:37AM -0600, dinguyen at altera.com wrote: > From: Dinh Nguyen > > Add minimal support for Altera's SOCFPGA Cyclone 5 hardware. [snip] > +/* > + * Write the reset manager register to cause reset > + */ > +__attribute__((noreturn)) void reset_cpu(ulong addr) Please add to the file and use __noreturn, thanks (but when adding the prototype to include/common.h spell it out like this, this is a known issue atm, we can't use in right now). > diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h b/arch/arm/include/asm/arch-kirkwood/cpu.h > index d28c51a..7a53c8f 100644 > --- a/arch/arm/include/asm/arch-kirkwood/cpu.h > +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h > @@ -155,7 +155,6 @@ struct kwgpio_registers { > /* > * functions > */ > -void reset_cpu(unsigned long ignored); > unsigned char get_random_hex(void); > unsigned int kw_sdram_bar(enum memory_bank bank); > unsigned int kw_sdram_bs(enum memory_bank bank); > diff --git a/arch/arm/include/asm/arch-orion5x/cpu.h b/arch/arm/include/asm/arch-orion5x/cpu.h > index 2f52ca8..17b9b69 100644 > --- a/arch/arm/include/asm/arch-orion5x/cpu.h > +++ b/arch/arm/include/asm/arch-orion5x/cpu.h > @@ -251,7 +251,6 @@ struct orion5x_ddr_addr_decode_registers { > /* > * functions > */ > -void reset_cpu(unsigned long ignored); > u32 orion5x_device_id(void); > u32 orion5x_device_rev(void); > unsigned int orion5x_winctrl_calcsize(unsigned int sizeval); The reset_cpu bugfix (which I am glad you're doing) needs to be a separate patch. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: