From: Thierry Reding <thierry.reding@avionic-design.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Mundt <lethal@linux-sh.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Metcalf <cmetcalf@tilera.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Chris Zankel <chris@zankel.net>,
Greg Ungerer <gerg@uclinux.org>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci
Subject: Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()
Date: Sat, 15 Sep 2012 09:53:01 +0200 [thread overview]
Message-ID: <20120915075301.GA31044@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <CAMuHMdWuR_tdMw9iVkaQ3D9p1HVU_L05ap=MzBuo1jLD6YdHHw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
> > --- a/drivers/pci/setup-irq.c
> > +++ b/drivers/pci/setup-irq.c
> > @@ -17,6 +17,14 @@
> > #include <linux/ioport.h>
> > #include <linux/cache.h>
> >
> > +void __devinit __weak pcibios_update_irq(struct pci_dev *dev, int irq)
> > +{
> > +#ifdef CONFIG_PCI_DEBUG
> > + printk(KERN_DEBUG "PCI: Assigning IRQ %02d to %s\n", irq,
> > + pci_name(dev));
>
> pr_debug()?
> Or even better, dev_dbg()?
The problem with pr_debug() and dev_dbg() is that they will be compiled
out if DEBUG is not defined. Perhaps we should pass -DDEBUG if PCI_DEBUG
is configured and make this dev_dbg()?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Mundt <lethal@linux-sh.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Metcalf <cmetcalf@tilera.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Chris Zankel <chris@zankel.net>,
Greg Ungerer <gerg@uclinux.org>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()
Date: Sat, 15 Sep 2012 09:53:01 +0200 [thread overview]
Message-ID: <20120915075301.GA31044@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <CAMuHMdWuR_tdMw9iVkaQ3D9p1HVU_L05ap=MzBuo1jLD6YdHHw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
> > --- a/drivers/pci/setup-irq.c
> > +++ b/drivers/pci/setup-irq.c
> > @@ -17,6 +17,14 @@
> > #include <linux/ioport.h>
> > #include <linux/cache.h>
> >
> > +void __devinit __weak pcibios_update_irq(struct pci_dev *dev, int irq)
> > +{
> > +#ifdef CONFIG_PCI_DEBUG
> > + printk(KERN_DEBUG "PCI: Assigning IRQ %02d to %s\n", irq,
> > + pci_name(dev));
>
> pr_debug()?
> Or even better, dev_dbg()?
The problem with pr_debug() and dev_dbg() is that they will be compiled
out if DEBUG is not defined. Perhaps we should pass -DDEBUG if PCI_DEBUG
is configured and make this dev_dbg()?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()
Date: Sat, 15 Sep 2012 07:53:01 +0000 [thread overview]
Message-ID: <20120915075301.GA31044@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <CAMuHMdWuR_tdMw9iVkaQ3D9p1HVU_L05ap=MzBuo1jLD6YdHHw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
> > --- a/drivers/pci/setup-irq.c
> > +++ b/drivers/pci/setup-irq.c
> > @@ -17,6 +17,14 @@
> > #include <linux/ioport.h>
> > #include <linux/cache.h>
> >
> > +void __devinit __weak pcibios_update_irq(struct pci_dev *dev, int irq)
> > +{
> > +#ifdef CONFIG_PCI_DEBUG
> > + printk(KERN_DEBUG "PCI: Assigning IRQ %02d to %s\n", irq,
> > + pci_name(dev));
>
> pr_debug()?
> Or even better, dev_dbg()?
The problem with pr_debug() and dev_dbg() is that they will be compiled
out if DEBUG is not defined. Perhaps we should pass -DDEBUG if PCI_DEBUG
is configured and make this dev_dbg()?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@avionic-design.de (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()
Date: Sat, 15 Sep 2012 09:53:01 +0200 [thread overview]
Message-ID: <20120915075301.GA31044@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <CAMuHMdWuR_tdMw9iVkaQ3D9p1HVU_L05ap=MzBuo1jLD6YdHHw@mail.gmail.com>
On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
> > --- a/drivers/pci/setup-irq.c
> > +++ b/drivers/pci/setup-irq.c
> > @@ -17,6 +17,14 @@
> > #include <linux/ioport.h>
> > #include <linux/cache.h>
> >
> > +void __devinit __weak pcibios_update_irq(struct pci_dev *dev, int irq)
> > +{
> > +#ifdef CONFIG_PCI_DEBUG
> > + printk(KERN_DEBUG "PCI: Assigning IRQ %02d to %s\n", irq,
> > + pci_name(dev));
>
> pr_debug()?
> Or even better, dev_dbg()?
The problem with pr_debug() and dev_dbg() is that they will be compiled
out if DEBUG is not defined. Perhaps we should pass -DDEBUG if PCI_DEBUG
is configured and make this dev_dbg()?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120915/e0fef5be/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Mundt <lethal@linux-sh.org>,
"David S. Miller" <davem@davemloft.net>,
Chris Metcalf <cmetcalf@tilera.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Chris Zankel <chris@zankel.net>,
Greg Ungerer <gerg@uclinux.org>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
linux-m68k@vger.kernel.org, linux-mips@linux-mips.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/2] PCI: Provide a default pcibios_update_irq()
Date: Sat, 15 Sep 2012 09:53:01 +0200 [thread overview]
Message-ID: <20120915075301.GA31044@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <CAMuHMdWuR_tdMw9iVkaQ3D9p1HVU_L05ap=MzBuo1jLD6YdHHw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Sat, Sep 15, 2012 at 09:32:10AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 14, 2012 at 10:44 PM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
> > --- a/drivers/pci/setup-irq.c
> > +++ b/drivers/pci/setup-irq.c
> > @@ -17,6 +17,14 @@
> > #include <linux/ioport.h>
> > #include <linux/cache.h>
> >
> > +void __devinit __weak pcibios_update_irq(struct pci_dev *dev, int irq)
> > +{
> > +#ifdef CONFIG_PCI_DEBUG
> > + printk(KERN_DEBUG "PCI: Assigning IRQ %02d to %s\n", irq,
> > + pci_name(dev));
>
> pr_debug()?
> Or even better, dev_dbg()?
The problem with pr_debug() and dev_dbg() is that they will be compiled
out if DEBUG is not defined. Perhaps we should pass -DDEBUG if PCI_DEBUG
is configured and make this dev_dbg()?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-15 7:53 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 20:44 [PATCH 1/2] PCI: Annotate pci_fixup_irqs with __devinit Thierry Reding
2012-09-14 20:44 ` Thierry Reding
2012-09-14 20:44 ` Thierry Reding
2012-09-14 20:44 ` Thierry Reding
2012-09-14 20:44 ` Thierry Reding
2012-09-14 20:44 ` [PATCH 2/2] PCI: Provide a default pcibios_update_irq() Thierry Reding
2012-09-14 20:44 ` Thierry Reding
2012-09-14 20:44 ` Thierry Reding
2012-09-14 20:44 ` Thierry Reding
2012-09-14 20:44 ` Thierry Reding
2012-09-15 7:32 ` Geert Uytterhoeven
2012-09-15 7:32 ` Geert Uytterhoeven
2012-09-15 7:32 ` Geert Uytterhoeven
2012-09-15 7:32 ` Geert Uytterhoeven
2012-09-15 7:32 ` Geert Uytterhoeven
2012-09-15 7:53 ` Thierry Reding [this message]
2012-09-15 7:53 ` Thierry Reding
2012-09-15 7:53 ` Thierry Reding
2012-09-15 7:53 ` Thierry Reding
2012-09-15 7:53 ` Thierry Reding
2012-09-15 22:22 ` Bjorn Helgaas
2012-09-15 22:22 ` Bjorn Helgaas
2012-09-15 22:22 ` Bjorn Helgaas
2012-09-15 22:22 ` Bjorn Helgaas
2012-09-15 22:22 ` Bjorn Helgaas
2012-09-15 22:22 ` Bjorn Helgaas
2012-09-15 22:23 ` Bjorn Helgaas
2012-09-15 22:23 ` Bjorn Helgaas
2012-09-15 22:23 ` Bjorn Helgaas
2012-09-15 22:23 ` Bjorn Helgaas
2012-09-15 22:23 ` Bjorn Helgaas
2012-09-15 22:23 ` Bjorn Helgaas
2012-09-16 6:50 ` Thierry Reding
2012-09-16 6:50 ` Thierry Reding
2012-09-16 6:50 ` Thierry Reding
2012-09-16 6:50 ` Thierry Reding
2012-09-16 6:50 ` Thierry Reding
2012-09-16 6:50 ` Thierry Reding
2012-09-15 7:32 ` Geert Uytterhoeven
2012-09-14 20:44 ` Thierry Reding
2012-09-14 20:53 ` [PATCH 1/2] PCI: Annotate pci_fixup_irqs with __devinit Bjorn Helgaas
2012-09-14 20:53 ` Bjorn Helgaas
2012-09-14 20:53 ` Bjorn Helgaas
2012-09-14 20:53 ` Bjorn Helgaas
2012-09-14 20:53 ` Bjorn Helgaas
2012-09-14 20:53 ` Bjorn Helgaas
2012-09-14 22:35 ` Greg Kroah-Hartman
2012-09-14 22:35 ` Greg Kroah-Hartman
2012-09-14 22:35 ` Greg Kroah-Hartman
2012-09-14 22:35 ` Greg Kroah-Hartman
2012-09-14 22:35 ` Greg Kroah-Hartman
2012-09-15 7:57 ` Thierry Reding
2012-09-15 7:57 ` Thierry Reding
2012-09-15 7:57 ` Thierry Reding
2012-09-15 7:57 ` Thierry Reding
2012-09-15 7:57 ` Thierry Reding
2012-09-15 7:57 ` Thierry Reding
2012-09-14 22:35 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120915075301.GA31044@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=bhelgaas@google.com \
--cc=chris@zankel.net \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=lethal@linux-sh.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.