From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Sun, 16 Sep 2012 09:46:52 +0200 Subject: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver In-Reply-To: <1347550912-18021-4-git-send-email-sebastian.hesselbarth@gmail.com> References: <1344689809-6223-1-git-send-email-sebastian.hesselbarth@gmail.com> <1347550912-18021-1-git-send-email-sebastian.hesselbarth@gmail.com> <1347550912-18021-4-git-send-email-sebastian.hesselbarth@gmail.com> Message-ID: <20120916074652.GM28177@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > +++ b/Documentation/devicetree/bindings/pinctrl/marvell,kirkwood-pinctrl.txt > @@ -0,0 +1,279 @@ > +* Marvell Kirkwood SoC pinctrl driver for mpp > + > +Please refer to marvell,mvebu-pinctrl.txt in this directory for common binding > +part and usage. > + > +Required properties: > +- compatible: "marvell,88f6180-pinctrl", > + "marvell,88f6190-pinctrl", "marvell,88f6192-pinctrl", > + "marvell,88f6281-pinctrl", "marvell,88f6282-pinctrl" > + > +This driver supports all kirkwood variants, i.e. 88f6180, 88f619x, and 88f628 Hi Sebastian The current MPP code determines for itself what chip it is running on. It can then check if a pin configuration is valid for the current run time environment. Here you are suggesting we have to put into the DT what chip we expect to be on. What is the advantage of this, over getting the information from the device itself? If i wanted to mass convert all existing kirkwood DT boards over to use pinctrl, im stuck at the very first step. I've no idea what chip they use, it was not relevant before. Thanks Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver Date: Sun, 16 Sep 2012 09:46:52 +0200 Message-ID: <20120916074652.GM28177@lunn.ch> References: <1344689809-6223-1-git-send-email-sebastian.hesselbarth@gmail.com> <1347550912-18021-1-git-send-email-sebastian.hesselbarth@gmail.com> <1347550912-18021-4-git-send-email-sebastian.hesselbarth@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1347550912-18021-4-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Sebastian Hesselbarth Cc: Thomas Petazzoni , Lior Amsalem , Russell King , Jason Cooper , Andrew Lunn , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Ben Dooks , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org > +++ b/Documentation/devicetree/bindings/pinctrl/marvell,kirkwood-pinctrl.txt > @@ -0,0 +1,279 @@ > +* Marvell Kirkwood SoC pinctrl driver for mpp > + > +Please refer to marvell,mvebu-pinctrl.txt in this directory for common binding > +part and usage. > + > +Required properties: > +- compatible: "marvell,88f6180-pinctrl", > + "marvell,88f6190-pinctrl", "marvell,88f6192-pinctrl", > + "marvell,88f6281-pinctrl", "marvell,88f6282-pinctrl" > + > +This driver supports all kirkwood variants, i.e. 88f6180, 88f619x, and 88f628 Hi Sebastian The current MPP code determines for itself what chip it is running on. It can then check if a pin configuration is valid for the current run time environment. Here you are suggesting we have to put into the DT what chip we expect to be on. What is the advantage of this, over getting the information from the device itself? If i wanted to mass convert all existing kirkwood DT boards over to use pinctrl, im stuck at the very first step. I've no idea what chip they use, it was not relevant before. Thanks Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751931Ab2IPHr3 (ORCPT ); Sun, 16 Sep 2012 03:47:29 -0400 Received: from londo.lunn.ch ([80.238.139.98]:36497 "EHLO londo.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702Ab2IPHr1 (ORCPT ); Sun, 16 Sep 2012 03:47:27 -0400 Date: Sun, 16 Sep 2012 09:46:52 +0200 From: Andrew Lunn To: Sebastian Hesselbarth Cc: Thomas Petazzoni , Grant Likely , Rob Herring , Rob Landley , Russell King , Lior Amsalem , Andrew Lunn , Jason Cooper , Gregory CLEMENT , Ben Dooks , Linus Walleij , Stephen Warren , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 03/10] pinctrl: mvebu: kirkwood pinctrl driver Message-ID: <20120916074652.GM28177@lunn.ch> References: <1344689809-6223-1-git-send-email-sebastian.hesselbarth@gmail.com> <1347550912-18021-1-git-send-email-sebastian.hesselbarth@gmail.com> <1347550912-18021-4-git-send-email-sebastian.hesselbarth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1347550912-18021-4-git-send-email-sebastian.hesselbarth@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +++ b/Documentation/devicetree/bindings/pinctrl/marvell,kirkwood-pinctrl.txt > @@ -0,0 +1,279 @@ > +* Marvell Kirkwood SoC pinctrl driver for mpp > + > +Please refer to marvell,mvebu-pinctrl.txt in this directory for common binding > +part and usage. > + > +Required properties: > +- compatible: "marvell,88f6180-pinctrl", > + "marvell,88f6190-pinctrl", "marvell,88f6192-pinctrl", > + "marvell,88f6281-pinctrl", "marvell,88f6282-pinctrl" > + > +This driver supports all kirkwood variants, i.e. 88f6180, 88f619x, and 88f628 Hi Sebastian The current MPP code determines for itself what chip it is running on. It can then check if a pin configuration is valid for the current run time environment. Here you are suggesting we have to put into the DT what chip we expect to be on. What is the advantage of this, over getting the information from the device itself? If i wanted to mass convert all existing kirkwood DT boards over to use pinctrl, im stuck at the very first step. I've no idea what chip they use, it was not relevant before. Thanks Andrew