Re: [Powertop] [PATCH 2/2] perf: Check return value of strdup

[Sergey Senozhatsky <sergey.senozhatsky at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

On (09/16/12 23:17), Namhyung Kim wrote:
> The strdup() can return NULL so that the result should be checked.
> 
> Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
> ---

looks good to me, thank you.

	-ss

>  src/perf/perf.cpp |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/perf/perf.cpp b/src/perf/perf.cpp
> index c8ba7a8..35b4017 100644
> --- a/src/perf/perf.cpp
> +++ b/src/perf/perf.cpp
> @@ -145,6 +145,11 @@ void perf_event::set_event_name(const char *event_name)
>  	if (name)
>  		free(name);
>  	name = strdup(event_name);
> +	if (!name) {
> +		fprintf(stderr, "failed to allocate event name\n");
> +		return;
> +	}
> +
>  	char *c;
>  
>  	c = strchr(name, ':');