From: Jonathan Corbet <corbet@lwn.net>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Ezequiel Garcia <elezegarcia@gmail.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/4] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init()
Date: Mon, 17 Sep 2012 09:36:36 -0600 [thread overview]
Message-ID: <20120917093636.635feb96@lwn.net> (raw)
In-Reply-To: <201209171610.43862.hverkuil@xs4all.nl>
On Mon, 17 Sep 2012 16:10:43 +0200
Hans Verkuil <hverkuil@xs4all.nl> wrote:
> Why WARN_ON_ONCE? I'd want to see this all the time, not just once.
>
> It's certainly better than BUG_ON, but I'd go for WARN_ON.
I like WARN_ON_ONCE better, myself. Avoids the risk of spamming the logs,
and once is enough to answer that "why doesn't my camera work?" question.
Don't feel all that strongly about it, though...
jon
next prev parent reply other threads:[~2012-09-17 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 13:43 [PATCH 1/4] videobuf2-core: Replace BUG_ON and return an error at vb2_queue_init() Ezequiel Garcia
2012-09-17 14:10 ` Hans Verkuil
2012-09-17 15:36 ` Jonathan Corbet [this message]
2012-09-17 15:41 ` Hans Verkuil
2012-09-17 15:47 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120917093636.635feb96@lwn.net \
--to=corbet@lwn.net \
--cc=elezegarcia@gmail.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.