From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Opensource [Anthony Olech]" <anthony.olech.opensource@diasemi.com>
Cc: Liam Girdwood <lrg@ti.com>, Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <khali@linux-fr.org>,
Randy Dunlap <rdunlap@xenotime.net>,
LKML <linux-kernel@vger.kernel.org>,
David Dajun Chen <david.chen@diasemi.com>
Subject: Re: [NEW DRIVER V3 8/8] DA9058 REGULATOR driver
Date: Mon, 17 Sep 2012 06:40:18 -0400 [thread overview]
Message-ID: <20120917104017.GB5401@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <24DF37198A1E704D9811D8F72B87EB51032CC96A@NB-EX-MBX02.diasemi.com>
On Mon, Sep 17, 2012 at 10:29:43AM +0000, Opensource [Anthony Olech] wrote:
> > Why is this function writing to the hardware, especially writing the same value
> > every time?
> the ramp_register is DA9058_SUPPLY_REG and it is marked as volitile.
> Writing to the ramp enable bit starts the voltage change. When the PMIC has
> finished making the change it resets the bit. Thus to make another voltage
> change the bit needs to be set again.
This function is retrieving the amount of time it would take to set the
voltage. Why would it be starting a voltage ramp? The fact that it's
not setting the new voltage in the hardware ought to be a warning sign
here...
next prev parent reply other threads:[~2012-09-17 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 15:05 [NEW DRIVER V3 8/8] DA9058 REGULATOR driver Anthony Olech
2012-08-27 16:50 ` Mark Brown
2012-09-17 10:29 ` Opensource [Anthony Olech]
2012-09-17 10:40 ` Mark Brown [this message]
2012-09-17 10:49 ` Opensource [Anthony Olech]
2012-09-17 11:15 ` Mark Brown
2012-09-17 11:23 ` Opensource [Anthony Olech]
2012-09-17 11:32 ` Mark Brown
2012-09-17 12:07 ` Opensource [Anthony Olech]
2012-09-19 2:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120917104017.GB5401@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anthony.olech.opensource@diasemi.com \
--cc=david.chen@diasemi.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lrg@ti.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.