From: Florian Westphal <fw@strlen.de>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] netfilter: xt_time: add support to ignore day transition
Date: Mon, 17 Sep 2012 13:02:29 +0200 [thread overview]
Message-ID: <20120917110229.GB9909@breakpoint.cc> (raw)
In-Reply-To: <alpine.LNX.2.01.1209171230550.21480@nerf07.vanv.qr>
Jan Engelhardt <jengelh@inai.de> wrote:
> >Currently, if you want to do something like:
> >"match Monday, starting 23:00, for two hours"
> >You need two rules, one for Mon 23:00 to 0:00 and one for Tue 0:00-1:00.
> >The rule
> >--weekdays Mo --timestart 23:00 --timestop 01:00
> >looks correct, but it will first match on monday from midnight to 1 a.m.
> >and then again for another hour from 23:00 onwards.
>
> I think stop < start should be outright rejected in the user interface
> because of its confusion potential. Given what it currently does, it
> does not seem like it was ever desired.
No, it works fine the way it is; in fact, the kernel
explicitly tests for stop < start to make things work.
Only when --weekdays is used with a stop < start rule
the behaviour gets weird.
next prev parent reply other threads:[~2012-09-17 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 10:23 [PATCH] libxt_time: add support to ignore day transition Florian Westphal
2012-09-17 10:23 ` [PATCH] netfilter: xt_time: " Florian Westphal
2012-09-17 10:32 ` Jan Engelhardt
2012-09-17 11:02 ` Florian Westphal [this message]
2012-09-24 12:35 ` Pablo Neira Ayuso
2012-09-24 12:40 ` [PATCH] libxt_time: " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120917110229.GB9909@breakpoint.cc \
--to=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.