From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: linux-next: build failure after merge of the final tree (arm-soc tree related) Date: Mon, 17 Sep 2012 14:29:31 +0000 Message-ID: <201209171429.31794.arnd@arndb.de> References: <20120917212615.91bc134d237dcd5968f9f549@canb.auug.org.au> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.126.171]:49849 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756416Ab2IQO3q (ORCPT ); Mon, 17 Sep 2012 10:29:46 -0400 In-Reply-To: <20120917212615.91bc134d237dcd5968f9f549@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: Olof Johansson , linux-arm-kernel@lists.infradead.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren On Monday 17 September 2012, Stephen Rothwell wrote: > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/mfd/twl-core.c:49:22: fatal error: plat/cpu.h: No such file or directory > > Caused by commit 7d7e1eba7e92 ("ARM: OMAP2+: Prepare for irqs.h removal"). > > I have added the following patch to restrict this driver to ARM until it > is fixed: > > From: Stephen Rothwell > Date: Mon, 17 Sep 2012 21:18:21 +1000 > Subject: [PATCH] ARM: retrict TWL4030_CORE to ARM while it is broken > > Signed-off-by: Stephen Rothwell Thanks! If it requires plat/cpu.h, it should actually be limited to CONFIG_ARCH_OMAP, otherwise we will get the same problem on non-OMAP ARM builds. From what I can tell, the problem is the clocks_init function, which is the only part that is not completely generic. The trivial workaround would be to enclose the "#include " statement in #ifdef CONFIG_ARCH_OMAP, but with the common clock code in place, we should probably be able to come up with a better solution that works independent of the omap platform. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 17 Sep 2012 14:29:31 +0000 Subject: linux-next: build failure after merge of the final tree (arm-soc tree related) In-Reply-To: <20120917212615.91bc134d237dcd5968f9f549@canb.auug.org.au> References: <20120917212615.91bc134d237dcd5968f9f549@canb.auug.org.au> Message-ID: <201209171429.31794.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 17 September 2012, Stephen Rothwell wrote: > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/mfd/twl-core.c:49:22: fatal error: plat/cpu.h: No such file or directory > > Caused by commit 7d7e1eba7e92 ("ARM: OMAP2+: Prepare for irqs.h removal"). > > I have added the following patch to restrict this driver to ARM until it > is fixed: > > From: Stephen Rothwell > Date: Mon, 17 Sep 2012 21:18:21 +1000 > Subject: [PATCH] ARM: retrict TWL4030_CORE to ARM while it is broken > > Signed-off-by: Stephen Rothwell Thanks! If it requires plat/cpu.h, it should actually be limited to CONFIG_ARCH_OMAP, otherwise we will get the same problem on non-OMAP ARM builds. From what I can tell, the problem is the clocks_init function, which is the only part that is not completely generic. The trivial workaround would be to enclose the "#include " statement in #ifdef CONFIG_ARCH_OMAP, but with the common clock code in place, we should probably be able to come up with a better solution that works independent of the omap platform. Arnd