From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] mfd: Fix compile for twl-core.c by removing cpu_is_omap usage Date: Mon, 17 Sep 2012 20:43:45 +0000 Message-ID: <201209172043.45461.arnd@arndb.de> References: <20120917202943.GV4521@atomide.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120917202943.GV4521@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Fengguang Wu , Stephen Rothwell , Paul Walmsley , Samuel Ortiz , Olof Johansson , Felipe Balbi List-Id: linux-omap@vger.kernel.org On Monday 17 September 2012, Tony Lindgren wrote: > Commit 7d7e1eba (ARM: OMAP2+: Prepare for irqs.h removal) broke > compile for non-omap as include plat/cpu.h was added: > > drivers/mfd/twl-core.c:49:22: fatal error: plat/cpu.h: No such file or directory > > This header was indirectly included earlier when SPARSE_IRQ was not > set, but does not exist on most platforms. > > Fix the problem by removing the cpu_is_omap usage that should > not exist in drivers at all. We can do this by adding proper > clock aliases for the twl-core.c drivers, and drop separate > handling for cases when clock framework is not available as > the behaviour will stay the same. > > Note that we need to add a platform device to avoid using the > i2c provided names that may be different on various omaps. > > Reported-by: Fengguang Wu > Reported-by: Stephen Rothwell > Cc: Paul Walmsley > Cc: Samuel Ortiz > Cc: Arnd Bergmann > Cc: Olof Johansson > Signed-off-by: Tony Lindgren Acked-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 17 Sep 2012 20:43:45 +0000 Subject: [PATCH] mfd: Fix compile for twl-core.c by removing cpu_is_omap usage In-Reply-To: <20120917202943.GV4521@atomide.com> References: <20120917202943.GV4521@atomide.com> Message-ID: <201209172043.45461.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 17 September 2012, Tony Lindgren wrote: > Commit 7d7e1eba (ARM: OMAP2+: Prepare for irqs.h removal) broke > compile for non-omap as include plat/cpu.h was added: > > drivers/mfd/twl-core.c:49:22: fatal error: plat/cpu.h: No such file or directory > > This header was indirectly included earlier when SPARSE_IRQ was not > set, but does not exist on most platforms. > > Fix the problem by removing the cpu_is_omap usage that should > not exist in drivers at all. We can do this by adding proper > clock aliases for the twl-core.c drivers, and drop separate > handling for cases when clock framework is not available as > the behaviour will stay the same. > > Note that we need to add a platform device to avoid using the > i2c provided names that may be different on various omaps. > > Reported-by: Fengguang Wu > Reported-by: Stephen Rothwell > Cc: Paul Walmsley > Cc: Samuel Ortiz > Cc: Arnd Bergmann > Cc: Olof Johansson > Signed-off-by: Tony Lindgren Acked-by: Arnd Bergmann