All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: navin patidar <navinp@cdac.in>
Cc: gregkh@linuxfoundation.org, mfm@muteddisk.com,
	devel@driverdev.osuosl.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd
Date: Tue, 18 Sep 2012 10:42:39 +0300	[thread overview]
Message-ID: <20120918074239.GM4587@mwanda> (raw)
In-Reply-To: <1347943616-5955-1-git-send-email-navinp@cdac.in>

On Tue, Sep 18, 2012 at 10:16:56AM +0530, navin patidar wrote:
> In response to "usbip detach -p [port_number]" user command,vhci_shoutdown_connection gets
> executed which kills tcp_tx,tcp_rx kernel threads and then vhci_device_reset resets
> all usb_device struct variables except kernel thread pointers.
> 
> so, at the time of vhci_hcd removal vhci_shoutdown_connection tries to kill kernel threads
> which are already killed.
> 

Obviously, the same question would apply here.  Why don't you do
this in the shutdown function?

regards,
dan carpenter


  reply	other threads:[~2012-09-18  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18  4:46 [PATCH] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd navin patidar
2012-09-18  7:42 ` Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-09-14  9:51 navin patidar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918074239.GM4587@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mfm@muteddisk.com \
    --cc=navinp@cdac.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.