From: Mel Gorman <mgorman@suse.de>
To: Petr Tesarik <ptesarik@suse.cz>
Cc: Jan Kara <jack@suse.cz>, Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org
Subject: Re: Does swap_set_page_dirty() calling ->set_page_dirty() make sense?
Date: Tue, 18 Sep 2012 11:02:15 +0100 [thread overview]
Message-ID: <20120918100215.GK11266@suse.de> (raw)
In-Reply-To: <201209181051.50541.ptesarik@suse.cz>
On Tue, Sep 18, 2012 at 10:51:50AM +0200, Petr Tesarik wrote:
> > <SNIP>
> >
> > So just one minor nit for Mel. SWP_FILE looks like a bit confusing name for
> > a flag that gets set only for some swap files ;) At least I didn't pay
> > attention to it because I thought it's set for all of them. Maybe call it
> > SWP_FILE_CALL_AOPS or something like that?
>
I guess it would be a slightly better name all right.
> Same here. In fact, I believed that other filesystems only work by accident
> (because they don't have to access the mapping). I'm not even sure about the
> semantics of the swap_activate operation. Is this documented somewhere?
>
Documentation/filesystems/vfs.txt *briefly* describes what swap_activate()
does even though now that I read it I see that it's inaccurate. It says
that it proxies to the address spaces swapin_[out|in] method but it really
gets proxied to the direct_IO interface for writes and readpage for reads
(direct_IO could have been used for reads but my recollection was that
the locking was very awkward).
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-18 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 16:35 Does swap_set_page_dirty() calling ->set_page_dirty() make sense? Jan Kara
2012-09-17 19:15 ` Hugh Dickins
2012-09-18 2:16 ` Jan Kara
2012-09-18 8:51 ` Petr Tesarik
2012-09-18 10:02 ` Mel Gorman [this message]
2012-09-18 9:58 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918100215.GK11266@suse.de \
--to=mgorman@suse.de \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.