All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [usb:usb-next 25/32] drivers/usb/serial/omninet.c:165:6: warning: unused variable 'i'
Date: Tue, 18 Sep 2012 14:28:42 +0000	[thread overview]
Message-ID: <20120918142842.GA15432@kroah.com> (raw)
In-Reply-To: <20120918140406.GA16749@localhost>

On Tue, Sep 18, 2012 at 10:04:06PM +0800, Fengguang Wu wrote:
> Hi Greg,
> 
> FYI, there are new compile warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
> head:   07764958947c381ef095fc69503c1ef1775f316e
> commit: 6e03b8cecbd836f729afe1a50814544baa5e5f97 [25/32] USB: Serial: omninet.c: remove debug module parameter
> config: x86_64-allmodconfig
> 
> All error/warnings:
> 
> drivers/usb/serial/omninet.c: In function 'omninet_read_bulk_callback':
> drivers/usb/serial/omninet.c:165:6: warning: unused variable 'i' [-Wunused-variable]
> 
> vim +165 drivers/usb/serial/omninet.c
>    155	#define OMNINET_HEADERLEN	sizeof(struct omninet_header)
>    156	#define OMNINET_BULKOUTSIZE 	(64 - OMNINET_HEADERLEN)
>    157	
>    158	static void omninet_read_bulk_callback(struct urb *urb)
>    159	{
>    160		struct usb_serial_port 	*port 	= urb->context;
>    161		unsigned char 		*data 	= urb->transfer_buffer;
>    162		struct omninet_header 	*header = (struct omninet_header *) &data[0];
>    163		int status = urb->status;
>    164		int result;
>  > 165		int i;

Ah, thanks, I missed that, now fixed up.

greg k-h

      reply	other threads:[~2012-09-18 14:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 14:04 [usb:usb-next 25/32] drivers/usb/serial/omninet.c:165:6: warning: unused variable 'i' Fengguang Wu
2012-09-18 14:28 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918142842.GA15432@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.