All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
To: Don Dutile <ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] intel-iommu: Default to non-coherent for domains unattached to iommus
Date: Tue, 18 Sep 2012 16:34:46 +0200	[thread overview]
Message-ID: <20120918143446.GO2505@amd.com> (raw)
In-Reply-To: <50587DE6.3000207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Tue, Sep 18, 2012 at 09:57:58AM -0400, Don Dutile wrote:
> And you can't apply Alex's original patch as-is, since the iommu_bmp
> structure element changed from a ptr to an array,
> (a snippet of) alex's patch looked like:
> +    i = find_first_bit(&domain->iommu_bmp, g_num_of_iommus);
> 
> and the correct patch with the change to iommu_bmp is:
> +    i = find_first_bit(domain->iommu_bmp, g_num_of_iommus);
> 
> and the reason why I re-posted it, vs fwd-ing the original patch
> & asking for inclusion.
> Additionally, the above patch is what the customer tested & verified.
> 
> So, if you made the above adjustment to Alex's patch,
> then the patch is ok.  If not, the above adjustment must be made.

Okay, fine then. I made the adjustment to Alex' patch and will push my
updated tree out after some compile-testing.


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

  parent reply	other threads:[~2012-09-18 14:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 19:55 [PATCH] intel-iommu: Default to non-coherent for domains unattached to iommus Donald Dutile
     [not found] ` <1347479705-33972-1-git-send-email-ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-18 11:59   ` Joerg Roedel
     [not found]     ` <20120918115937.GB9939-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2012-09-18 13:57       ` Don Dutile
     [not found]         ` <50587DE6.3000207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-18 14:34           ` Joerg Roedel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-11-11 22:49 Alex Williamson
2011-11-12  0:17 ` Chris Wright
2011-11-12  0:37 ` David Woodhouse
2011-11-12  0:45   ` Chris Wright
2011-11-12  0:47     ` Chris Wright
2011-11-12  0:51     ` David Woodhouse
2011-11-12  0:58       ` Chris Wright
2011-11-12  1:03         ` David Woodhouse
2011-11-12  0:46   ` Roland Dreier
2011-11-12  0:51     ` Chris Wright
2011-11-12  0:55       ` David Woodhouse
2011-11-12  1:08         ` Chris Wright
2011-11-12  1:20           ` David Woodhouse
2011-11-15  7:12             ` cody
2011-11-15  4:54               ` Chris Wright
2011-11-15  5:55                 ` Kai Huang
2011-11-12  1:30           ` Roland Dreier
2012-08-27 20:22 ` Craig Hada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120918143446.GO2505@amd.com \
    --to=joerg.roedel-5c7gfcevmho@public.gmane.org \
    --cc=ddutile-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.