From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH 0/6] llc2: Simplify llc_station Date: Tue, 18 Sep 2012 18:49:55 +0100 Message-ID: <20120918174955.GD29217@decadent.org.uk> References: <1347764982.13258.207.camel@deadeye.wl.decadent.org.uk> <20120917.130531.941621987417626917.davem@davemloft.net> <20120917.131017.1646567691887140571.davem@davemloft.net> <20120917.131237.518528991078697534.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: acme@ghostprotocols.net, netdev@vger.kernel.org To: David Miller Return-path: Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:50567 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367Ab2IRRuA (ORCPT ); Tue, 18 Sep 2012 13:50:00 -0400 Content-Disposition: inline In-Reply-To: <20120917.131237.518528991078697534.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Sep 17, 2012 at 01:12:37PM -0400, David Miller wrote: > From: David Miller > Date: Mon, 17 Sep 2012 13:10:17 -0400 (EDT) > > > From: David Miller > > Date: Mon, 17 Sep 2012 13:05:31 -0400 (EDT) > > > >> From: Ben Hutchings > >> Date: Sun, 16 Sep 2012 04:09:42 +0100 > >> > >>> There seem to have been some grand plans for llc_station, but as they > >>> haven't been fulfilled it's just unnecessarily complicated. > >> > >> I went over these a few times, they look correct, so I am going > >> to apply them to net-next. > >> > >> If there are any problems let's hope that exposure in the tree > >> helps shake those out. > > > > It doesn't even build properly, please fix this and resubmit: > > > > ERROR: "sysctl_llc_station_ack_timeout" [net/llc/llc2.ko] undefined! > > Actually, since I trusted you when you said you build tested this, > I pushed it out to net-next pre-maturely. > > I'm going to fix this meanwhile by simply removing the sysctl that > references this symbol. > > But you need to check for me whether that's ok or not. The sysctl had no effect so I think it's fairly safe to assume nothing depends on it. Thanks. Ben. -- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus