All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	"David S. Miller" <davem@davemloft.net>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] compat: fs: Generic compat_sys_sendfile implementation
Date: Tue, 18 Sep 2012 18:13:05 +0000	[thread overview]
Message-ID: <201209181813.06124.arnd@arndb.de> (raw)
In-Reply-To: <1347987727-13739-1-git-send-email-catalin.marinas@arm.com>

On Tuesday 18 September 2012, Catalin Marinas wrote:
> @@ -229,7 +229,7 @@ COMPAT_SYS_SPU(sched_setaffinity)
>  COMPAT_SYS_SPU(sched_getaffinity)
>  SYSCALL(ni_syscall)
>  SYSCALL(ni_syscall)
> -SYS32ONLY(sendfile64)
> +SYS32ONLY(sendfile64_wrapper)
>  COMPAT_SYS_SPU(io_setup)
>  SYSCALL_SPU(io_destroy)
>  COMPAT_SYS_SPU(io_getevents)

I believe this will break native ppc32 builds because there is
no sys_sendfile64_wrapper function. You probably have to use

SYSX(sys_ni_syscall, compat_sys_sendfile64_wrapper, sys_sendfile64)

	Arnd

  reply	other threads:[~2012-09-18 18:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-18 17:02 [PATCH] compat: fs: Generic compat_sys_sendfile implementation Catalin Marinas
2012-09-18 18:13 ` Arnd Bergmann [this message]
2012-09-19 10:57   ` Catalin Marinas
2012-09-18 20:06 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209181813.06124.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.