From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 08/11] package/pulseaudio: fix build-dependency on gettext
Date: Tue, 18 Sep 2012 19:58:40 +0200 [thread overview]
Message-ID: <20120918195840.7d2af5af@skate> (raw)
In-Reply-To: <1347836276-24262-9-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Mon, 17 Sep 2012 00:57:53 +0200, Yann E. MORIN wrote:
> In its Config.in, pulseaudio declares a dependency on gettext
> using the documented construct:
> select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
>
> but in its .mk file, declares a dependency on the package:
> PULSEAUDIO_DEPENDENCIES = [...] $(if $(BR2_PACKAGE_GETTEXT),gettext) [...]
>
> instead of the documented:
> $(if $(BR2_NEEDS_GETTEXT),gettext)
>
> Fix that.
Some other packages seem to suffer from the same problem, for example
diffutils. Why are you fixing pulseaudio separately, and not diffutils,
which gets fixed in your 11/11 patch:
-DIFFUTILS_DEPENDENCIES = \
- $(if $(BR2_PACKAGE_GETTEXT),gettext)
+DIFFUTILS_DEPENDENCIES = $(gettext)
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-09-18 17:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 22:57 [Buildroot] [PATCH 0/11 v3] Rework the gettext handling Yann E. MORIN
2012-09-16 22:57 ` [Buildroot] [PATCH 01/11] gettext: remove option to build statically Yann E. MORIN
2012-09-16 22:57 ` [Buildroot] [PATCH 02/11] gettext: remove the gettext-target make target, unused Yann E. MORIN
2012-09-16 22:57 ` [Buildroot] [PATCH 03/11] gettext: remove libintl handling Yann E. MORIN
2012-09-16 22:57 ` [Buildroot] [PATCH 04/11] Remove all references to libintl Yann E. MORIN
2012-09-16 22:57 ` [Buildroot] [PATCH 05/11] gettext: convert to autotools-package Yann E. MORIN
2012-09-20 19:44 ` Arnout Vandecappelle
2012-09-20 19:46 ` Arnout Vandecappelle
2012-09-21 6:33 ` Peter Korsgaard
2012-09-16 22:57 ` [Buildroot] [PATCH 06/11] doc: update after gettext changes Yann E. MORIN
2012-09-16 22:57 ` [Buildroot] [PATCH 07/11] package/lshw: add missing dependency on gettext Yann E. MORIN
2012-09-16 22:57 ` [Buildroot] [PATCH 08/11] package/pulseaudio: fix build-dependency " Yann E. MORIN
2012-09-18 17:58 ` Thomas Petazzoni [this message]
2012-09-18 20:45 ` Yann E. MORIN
2012-09-16 22:57 ` [Buildroot] [PATCH 09/11] toolchain/common: rename BR2_NEEDS_GETTEXT Yann E. MORIN
2012-09-20 22:21 ` Arnout Vandecappelle
2012-09-21 5:10 ` Thomas Petazzoni
2012-09-16 22:57 ` [Buildroot] [PATCH 10/11] toolchain/common: introduce blind options BR2_NEEDS_GETTEXT{, _IF_LOCALE} Yann E. MORIN
2012-09-18 17:55 ` Thomas Petazzoni
2012-09-18 21:16 ` Samuel Martin
2012-09-18 21:28 ` Yann E. MORIN
2012-09-20 18:53 ` Thomas Petazzoni
2012-09-20 22:29 ` Arnout Vandecappelle
2012-09-20 22:24 ` Arnout Vandecappelle
2012-09-21 5:13 ` Thomas Petazzoni
2012-09-16 22:57 ` [Buildroot] [PATCH 11/11] packages: use the new gettext mechanism Yann E. MORIN
2012-09-18 21:17 ` [Buildroot] [PATCH 0/11 v3] Rework the gettext handling Samuel Martin
2012-09-19 21:11 ` Arnout Vandecappelle
2012-09-19 22:53 ` Arnout Vandecappelle
2012-09-20 16:50 ` Yann E. MORIN
2012-09-20 18:47 ` Thomas Petazzoni
2012-09-20 18:49 ` Thomas Petazzoni
2012-09-20 19:42 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2012-09-03 22:02 [Buildroot] [PATCH 0/11 v2] " Yann E. MORIN
2012-09-03 22:02 ` [Buildroot] [PATCH 08/11] package/pulseaudio: fix build-dependency on gettext Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918195840.7d2af5af@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.