From: Olaf Hering <olaf@aepfle.de>
To: M A Young <m.a.young@durham.ac.uk>
Cc: Steven Haigh <netwiz@crc.id.au>, xen-devel@lists.xen.org
Subject: Re: Problems building qemu-xen-dir tools
Date: Tue, 18 Sep 2012 23:56:05 +0200 [thread overview]
Message-ID: <20120918215605.GA9974@aepfle.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1209181938500.21507@procyon.dur.ac.uk>
On Tue, Sep 18, M A Young wrote:
> On Tue, 18 Sep 2012, Olaf Hering wrote:
>
> >On Wed, Sep 19, Steven Haigh wrote:
> >
> >>Without this, the build fails due to incompatible CFLAGS.
> >
> >CFLAGS must not be in environment, otherwise make will append its own
> >CFLAGS to that environment variable and pass it on to qemu. qemu itself
> >is not ready for things like -std=gnu99.
>
> The problem is that packaging guidelines often want you to set CFLAGS to
> supply distribution standard compile options. On the other hand with
> something like qemu it means that someone has probably already solved the
> problem. The attached patch worked for me in testing, which I derived by
> comparing Fedora's qemu with xen's.
qemu does not build with rPM_OPT_FLAGS, at least in SuSE.
For Xen, see changeset: 25464:75a2bb5db228
user: Olaf Hering <olaf@aepfle.de>
date: Thu Jun 07 18:51:42 2012 +0100
files: tools/Makefile tools/Rules.mk tools/firmware/Rules.mk
description:
tools: pass EXTRA_CFLAGS via environment
Olaf
next prev parent reply other threads:[~2012-09-18 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 14:28 Problems building qemu-xen-dir tools Steven Haigh
2012-09-18 14:35 ` Olaf Hering
2012-09-18 18:48 ` M A Young
2012-09-18 21:56 ` Olaf Hering [this message]
2012-09-18 23:34 ` M A Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918215605.GA9974@aepfle.de \
--to=olaf@aepfle.de \
--cc=m.a.young@durham.ac.uk \
--cc=netwiz@crc.id.au \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.