From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/5] ASoC: fsl: remove unnecessary call to dma_unmap_single
Date: Tue, 18 Sep 2012 22:35:40 -0400 [thread overview]
Message-ID: <20120919023539.GF8832@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347657278-25295-3-git-send-email-timur@freescale.com>
On Fri, Sep 14, 2012 at 04:14:36PM -0500, Timur Tabi wrote:
> Remove a call to dma_unmap_single() from the PowerPC ASoC DMA driver. The
> buffer is allocated and not actually mapped, so the unmap call doesn't
> make sense. It was probably left over from some early version of the driver.
>
> This bug was unnoticed for so long because the DMA mapping functions normally
> don't do anything on PowerPC.
Applied, thanks.
next prev parent reply other threads:[~2012-09-19 2:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 21:14 [PATCH 1/5] [v3] ASoC: fsl: use snd_soc_register_card to register the card Timur Tabi
2012-09-14 21:14 ` [PATCH 2/5] ASoC: fsl: move machine drivers to late_initcall() Timur Tabi
2012-09-19 2:35 ` Mark Brown
2012-09-14 21:14 ` [PATCH 3/5] ASoC: fsl: remove unnecessary call to dma_unmap_single Timur Tabi
2012-09-19 2:35 ` Mark Brown [this message]
2012-09-14 21:14 ` [PATCH 4/5] ASoC: wm8960: add support for big-endian audio samples Timur Tabi
2012-09-19 2:34 ` Mark Brown
2012-09-19 2:58 ` Tabi Timur-B04825
2012-09-19 3:13 ` Mark Brown
2012-09-14 21:14 ` [PATCH 5/5] ASoC: add support for the Freescale / iVeia P1022 RDK reference board Timur Tabi
2012-09-19 2:32 ` Mark Brown
2012-09-19 2:47 ` Tabi Timur-B04825
2012-09-19 3:12 ` Mark Brown
2012-09-19 15:17 ` Timur Tabi
2012-09-19 2:35 ` [PATCH 1/5] [v3] ASoC: fsl: use snd_soc_register_card to register the card Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919023539.GF8832@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.