From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: Destroy the planes prior to destroying the associated CRTC Date: Wed, 19 Sep 2012 11:34:53 +0200 Message-ID: <20120919093452.GD1676@bremse> References: <1347874683-21191-1-git-send-email-chris@chris-wilson.co.uk> <20120917075559.67918909@jbarnes-desktop> <6c3329$64lfus@orsmga002.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qc0-f177.google.com (mail-qc0-f177.google.com [209.85.216.177]) by gabe.freedesktop.org (Postfix) with ESMTP id BC8189EB19 for ; Wed, 19 Sep 2012 02:34:57 -0700 (PDT) Received: by qcsu28 with SMTP id u28so676906qcs.36 for ; Wed, 19 Sep 2012 02:34:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <6c3329$64lfus@orsmga002.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org, stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Mon, Sep 17, 2012 at 04:04:23PM +0100, Chris Wilson wrote: > On Mon, 17 Sep 2012 07:55:59 -0700, Jesse Barnes wrote: > > Yeah, looks good. Did we used to not touch the crtc in the plane > > cleanup? Either way this is safer. > > I think the bug only came to light because QA is now routinely running > with slub_debug. And QA now confirmed that this patch fixes things: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54101 Tested-by: lu hua -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch