Re: Return status of mnt_context_mount when helper is used

[Karel Zak <kzak@redhat.com>]

On Tue, Sep 18, 2012 at 11:08:16PM +0000, Amit wrote:
> Hello,
> 
> When trying to mount samba shares using *mnt_context_mount*, the
> *mount.cifs* helper is called and used. This allows for automatic
> resolving of hostnames.
> 
> However, if the hostname is not valid and the resolve fails,
> the call *mnt_context_mount* is still successful. Using
> *mnt_init_debug*, the mount.cifs helper returns an error code but this
> is not propagated to the status of mnt_context_mount or
> mnt_context_get_status.

docs:

 * mnt_context_get_status:
 * @cxt: mount context
 *
 * Global libmount status.
 *
 * The real exit code of the mount.type helper has to be tested
 * by  mnt_context_get_helper_status(). The mnt_context_get_status()
 * only inform that exec() has been successful.

> This has been tried with util-linux 2.20.1 and the latest util-linux
> from git (as of today).
> 
> Is there a way to check the return status of the helper?
> 
> START TRACE
> 
> mount error: could not resolve address for pmanalo-pc2: Unknown error
> libmount:      CXT: [0x811010]: /sbin/mount.cifs executed [status=1]
> libmount:      CXT: [0x811010]: don't update: external helper
> mount_cifs: mnt_context_mount return code = 0 status = 1
> mount_cifs: error:
> libmount:      CXT: [0x811010]: <---- reset [status=1] ---->
> libmount:    CACHE: [0x811350]: free
> libmount:      CXT: [0x811010]: <---- free


 See sys-utils/mount.c: mk_exit_code()

   if (mnt_context_helper_executed(cxt))
      mnt_context_get_helper_status(cxt);

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com