From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Wed, 19 Sep 2012 12:50:54 +0200 Subject: [PATCH] ARM: mxs: m28evk: Disable OCOTP OUI loading In-Reply-To: <50599F96.5040600@free-electrons.com> References: <1348007837-23187-1-git-send-email-marex@denx.de> <20120919031526.GC6460@S2100-06.ap.freescale.net> <50599F96.5040600@free-electrons.com> Message-ID: <201209191250.54418.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Maxime Ripard, > Hi Shawn, > > Le 19/09/2012 05:15, Shawn Guo a ?crit : > > On Wed, Sep 19, 2012 at 12:37:17AM +0200, Marek Vasut wrote: > >> Don't load the FEC MAC address from OCOTP, but use the one supplied > >> via device tree by U-Boot. This is the preferred way, every DT-capable > >> bootloader does set up "mac-address" and "local-mac-address" properties > >> into the DT passed to the kernel. > > > > Ok, since you are the maintainer of m28evk board, it could be your call > > to do so. While for imx28-evk, the kernel at least runs with bootlets > > which is not DT capable. > > > >> Signed-off-by: Marek Vasut > >> Cc: Fabio Estevam > >> Cc: Shawn Guo > >> --- > >> > >> arch/arm/mach-mxs/mach-mxs.c | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c > >> index 170a930..71d47f5 100644 > >> --- a/arch/arm/mach-mxs/mach-mxs.c > >> +++ b/arch/arm/mach-mxs/mach-mxs.c > >> @@ -255,8 +255,6 @@ static void __init imx28_evk_post_init(void) > >> > >> static void __init m28evk_init(void) > >> { > >> > >> - update_fec_mac_prop(OUI_DENX); > >> - > > > > Since it's the only user of OUI_DENX, can we remove enum mac_oui > > completely and make update_fec_mac_prop a fsl specific call? > > I have a patch on the way that adds the Crystalfontz OUI for the > CFA-10049, so it will be quite useful to me in the future. Do you use U-Boot on that board? > Maxime Best regards, Marek Vasut