From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V6 1/2] of: Add generic device tree DMA helpers Date: Wed, 19 Sep 2012 14:24:55 +0000 Message-ID: <201209191424.56086.arnd@arndb.de> References: <1347662517-4210-1-git-send-email-jon-hunter@ti.com> <1347662517-4210-2-git-send-email-jon-hunter@ti.com> <20120919140705.GB16522@beef> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120919140705.GB16522@beef> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Matt Porter Cc: Stephen Warren , Vinod Koul , device-tree , Rob Herring , Dan Williams , Russell King , linux-omap , linux-arm List-Id: linux-omap@vger.kernel.org On Wednesday 19 September 2012, Matt Porter wrote: > > +Optional properties: > > +- #dma-channels: Number of DMA channels supported by the controller. > > +- #dma-requests: Number of DMA requests signals supported by the > > + controller. > > Shouldn't these two optional properties drop the prefix #? By > convention adopted from the various original OF/ePAPR/etc specs, the > only properties I would expect to see with this prefix are the > "*-cells" cell sizes. A quick search indicates this is the case > throughout all the current bindings. I always assumed that the # prefix is used to indicate that we are counting things instead of listing them. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 19 Sep 2012 14:24:55 +0000 Subject: [PATCH V6 1/2] of: Add generic device tree DMA helpers In-Reply-To: <20120919140705.GB16522@beef> References: <1347662517-4210-1-git-send-email-jon-hunter@ti.com> <1347662517-4210-2-git-send-email-jon-hunter@ti.com> <20120919140705.GB16522@beef> Message-ID: <201209191424.56086.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 19 September 2012, Matt Porter wrote: > > +Optional properties: > > +- #dma-channels: Number of DMA channels supported by the controller. > > +- #dma-requests: Number of DMA requests signals supported by the > > + controller. > > Shouldn't these two optional properties drop the prefix #? By > convention adopted from the various original OF/ePAPR/etc specs, the > only properties I would expect to see with this prefix are the > "*-cells" cell sizes. A quick search indicates this is the case > throughout all the current bindings. I always assumed that the # prefix is used to indicate that we are counting things instead of listing them. Arnd