Re: [RFC PATCH 2/5] mfd: introduce retu-mfd driver

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Aaro,

On Wed, Aug 29, 2012 at 12:34:24AM +0300, Aaro Koskinen wrote:
> Retu is a multi-function device found on Nokia Internet Tablets
> implementing at least watchdog, RTC, headset detection and power button
> functionality.
> 
> This patch implements a minimum functionality providing only register
> access functions.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> Cc: sameo@linux.intel.com
> ---
>  drivers/mfd/Kconfig      |    8 +++
>  drivers/mfd/Makefile     |    1 +
>  drivers/mfd/retu-mfd.c   |  114 ++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/retu.h |   20 ++++++++
>  4 files changed, 143 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mfd/retu-mfd.c
>  create mode 100644 include/linux/mfd/retu.h
Besides Felipe's comments, you probably want to use regmap I2C for this
driver.


> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index b1a1462..8ca1270 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1003,6 +1003,14 @@ config MFD_PALMAS
>  	  If you say yes here you get support for the Palmas
>  	  series of PMIC chips from Texas Instruments.
>  
> +config MFD_RETU
> +	tristate "Support for Retu multi-function device"
> +	select MFD_CORE
> +	depends on I2C
> +	help
> +	  Retu is a multi-function device found on Nokia Internet Tables
> +	  (770, N800 and N810).
Which sub devices does it come with ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/