From: Stephen Hemminger <shemminger@vyatta.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
mlindner@marvell.com, linux-kernel@vger.kernel.org
Subject: Re: [patch net] sky2: fix rx filter setup on link up
Date: Wed, 19 Sep 2012 16:04:38 -0700 [thread overview]
Message-ID: <20120919160438.52ed0b1a@s6510.linuxnetplumber.net> (raw)
In-Reply-To: <20120919203825.GA1460@minipsycho.orion>
On Wed, 19 Sep 2012 22:38:25 +0200
Jiri Pirko <jiri@resnulli.us> wrote:
> You cannot call sky2_set_multicast() directly here. It is called from
> __dev_set_rx_mode(). You would have to take at lease netif_addr_lock()
> here. I think that clearer is to remember computed value....
Ugh, it would mean changing link_up to being done via workqueue.
But your code wasnt safe against changes to values from set_multicast race
either.
next prev parent reply other threads:[~2012-09-19 23:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 15:10 [patch net] sky2: fix rx filter setup on link up Jiri Pirko
2012-09-17 16:12 ` Stephen Hemminger
2012-09-17 20:47 ` Jiri Pirko
2012-09-17 21:15 ` Stephen Hemminger
2012-09-18 6:13 ` Jiri Pirko
2012-09-18 20:25 ` David Miller
2012-09-18 0:38 ` Mirko Lindner
2012-09-18 6:15 ` Jiri Pirko
2012-10-04 7:40 ` Jiri Pirko
2012-10-08 9:44 ` Mirko Lindner
2012-09-19 20:22 ` Stephen Hemminger
2012-09-19 20:38 ` Jiri Pirko
2012-09-19 23:04 ` Stephen Hemminger [this message]
2012-09-22 20:14 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919160438.52ed0b1a@s6510.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.