[staging:staging-next 86/151] drivers/staging/iio/iio_hwmon.c:96:21-27: ERROR: application of sizeof

[Fengguang Wu <fengguang.wu@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

Hi Lars-Peter,

FYI, there are new coccinelle warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
head:   5d06e3df280bd230e2eadc16372e62818c63e894
commit: a0e545e0e75006a7de0e9bc5397f6b44c61990b2 [86/151] staging:iio:hwmon bridge: Use iio_read_channel_processed

All coccinelle warnings:

+ drivers/staging/iio/iio_hwmon.c:96:21-27: ERROR: application of sizeof to pointer

vim +96 drivers/staging/iio/iio_hwmon.c
    86		st->channels = iio_channel_get_all(dev_name(&pdev->dev));
    87		if (IS_ERR(st->channels)) {
    88			ret = PTR_ERR(st->channels);
    89			goto error_free_state;
    90		}
    91	
    92		/* count how many attributes we have */
    93		while (st->channels[st->num_channels].indio_dev)
    94			st->num_channels++;
    95	
  > 96		st->attrs = kzalloc(sizeof(st->attrs) * (st->num_channels + 1),
    97				    GFP_KERNEL);
    98		if (st->attrs == NULL) {
    99			ret = -ENOMEM;
   100			goto error_release_channels;
   101		}
   102		for (i = 0; i < st->num_channels; i++) {
   103			a = kzalloc(sizeof(*a), GFP_KERNEL);
   104			if (a == NULL) {
   105				ret = -ENOMEM;
   106				goto error_free_attrs;

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

[-- Attachment #2: noderef-iio_hwmon.patch --]
[-- Type: text/x-diff, Size: 918 bytes --]

[PATCH] iio_hwmon: fix coccinelle warnings

/c/kernel-tests/src/linux/drivers/staging/iio/iio_hwmon.c:96:21-27: ERROR: application of sizeof to pointer

 sizeof when applied to a pointer typed expression gives the size of
 the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 cocci-output-20562-fb0f2b-iio_hwmon.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/iio/iio_hwmon.c
+++ b/drivers/staging/iio/iio_hwmon.c
@@ -93,7 +93,7 @@ static int __devinit iio_hwmon_probe(str
 	while (st->channels[st->num_channels].indio_dev)
 		st->num_channels++;
 
-	st->attrs = kzalloc(sizeof(st->attrs) * (st->num_channels + 1),
+	st->attrs = kzalloc(sizeof(*st->attrs) * (st->num_channels + 1),
 			    GFP_KERNEL);
 	if (st->attrs == NULL) {
 		ret = -ENOMEM;