All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] pcsc-lite: new package
Date: Wed, 19 Sep 2012 16:47:06 +0200	[thread overview]
Message-ID: <20120919164706.0e38b54d@skate> (raw)
In-Reply-To: <1348059150-32601-1-git-send-email-waldemar.rymarkiewicz@tieto.com>

Dear Waldemar Rymarkiewicz,

On Wed, 19 Sep 2012 14:52:29 +0200, Waldemar Rymarkiewicz wrote:
> +# libudev has a priority over libusb
> +ifneq ($(BR2_PACKAGE_UDEV),y)
> +PCSC_LITE_CONF_OPT += --disable-libudev
> +
> +ifeq ($(BR2_PACKAGE_LIBUSB),y)
> +PCSC_LITE_CONF_OPT += --enable-libusb
> +PCSC_LITE_DEPENDENCIES += libusb
> +else
> +PCSC_LITE_CONF_OPT += --disable-libusb
> +endif
> +
> +endif

Can you detail this? I haven't looked at pcsc-lite itself, but this
looks strange. So if it is correct, it anyway needs a more detailed
comment.

Why when udev is available you don't do need libusb? Also, if udev is
available, you need to add it to the list of dependencies.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2012-09-19 14:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 12:52 [Buildroot] [PATCH v2 1/2] pcsc-lite: new package Waldemar Rymarkiewicz
2012-09-19 12:52 ` [Buildroot] [PATCH v2 2/2] ccid: " Waldemar Rymarkiewicz
2012-09-19 20:56   ` Arnout Vandecappelle
2012-09-20  6:31     ` Waldemar.Rymarkiewicz at tieto.com
2012-09-19 14:47 ` Thomas Petazzoni [this message]
2012-09-20  6:10   ` [Buildroot] [PATCH v2 1/2] pcsc-lite: " Waldemar.Rymarkiewicz at tieto.com
2012-09-20  7:36     ` Samuel Martin
2012-09-20  8:01       ` Waldemar.Rymarkiewicz at tieto.com
2012-09-20  9:27     ` Arnout Vandecappelle
2012-09-20 10:22     ` Thomas Petazzoni
2012-09-19 20:41 ` Arnout Vandecappelle
2012-09-20  6:12   ` Waldemar.Rymarkiewicz at tieto.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120919164706.0e38b54d@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.