All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: Shubhrajyoti D <shubhrajyoti@ti.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matt Porter <mporter@ti.com>,
	Koen Kooi <koen@dominion.thruhere.net>,
	Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH 2/2] OMAP i2c: pinctrl-ify i2c-omap.c
Date: Wed, 19 Sep 2012 10:24:10 -0700	[thread overview]
Message-ID: <20120919172410.GF11762@atomide.com> (raw)
In-Reply-To: <1348122889-28271-3-git-send-email-panto@antoniou-consulting.com>

* Pantelis Antoniou <panto@antoniou-consulting.com> [120919 01:40]:
> Add support for pinctrl mux settings in the OMAP I2C driver.
> If no such pinctl bindings are found a warning message is printed.
> 
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/i2c/busses/i2c-omap.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index b149e32..d192614 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -43,6 +43,7 @@
>  #include <linux/slab.h>
>  #include <linux/i2c-omap.h>
>  #include <linux/pm_runtime.h>
> +#include <linux/pinctrl/consumer.h>
>  
>  /* I2C controller revisions */
>  #define OMAP_I2C_OMAP1_REV_2		0x20
> @@ -1057,6 +1058,7 @@ omap_i2c_probe(struct platform_device *pdev)
>  	const struct of_device_id *match;
>  	int irq;
>  	int r;
> +	struct pinctrl *pinctrl;
>  
>  	/* NOTE: driver uses the static register mapping */
>  	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> @@ -1197,6 +1199,10 @@ omap_i2c_probe(struct platform_device *pdev)
>  
>  	of_i2c_register_devices(adap);
>  
> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> +	if (IS_ERR(pinctrl))
> +		dev_warn(dev->dev, "pins are not configured from the driver\n");
> +
>  	pm_runtime_mark_last_busy(dev->dev);
>  	pm_runtime_put_autosuspend(dev->dev);
>  
> -- 
> 1.7.12
> 

  parent reply	other threads:[~2012-09-19 17:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 16:07 [PATCH 0/3] Pinctrl-fy OMAP I2C driver Pantelis Antoniou
2012-09-19 16:07 ` [PATCH 1/3] pinctrl: pinctrl-single must be initialized early Pantelis Antoniou
2012-09-18 18:21   ` Tony Lindgren
2012-09-18 19:10     ` Pantelis Antoniou
2012-09-21  0:09       ` Tony Lindgren
2012-09-19 16:07 ` [PATCH 2/3] OMAP i2c: pinctrl-ify i2c-omap.c Pantelis Antoniou
2012-09-18 18:23   ` Tony Lindgren
2012-09-18 19:37     ` Pantelis Antoniou
2012-09-19  7:09   ` Shubhrajyoti
2012-09-19  8:34     ` Pantelis Antoniou
2012-09-20  6:34     ` [PATCH 0/2] Pinctrl-fy OMAP I2C driver (V2) Pantelis Antoniou
2012-09-20  6:34       ` [PATCH 1/2] pinctrl: pinctrl-single must be initialized early Pantelis Antoniou
2012-09-20  6:34       ` [PATCH 2/2] OMAP i2c: pinctrl-ify i2c-omap.c Pantelis Antoniou
2012-09-19 10:13         ` Shubhrajyoti Datta
2012-09-19 17:24         ` Tony Lindgren [this message]
2012-09-21  7:29   ` [PATCH 2/3] " Peter Ujfalusi
2012-09-21  7:34     ` Pantelis Antoniou
2012-09-19 16:07 ` [PATCH 3/3] i2c: OMAP fix driver initialization message Pantelis Antoniou
2012-09-18 18:24   ` Tony Lindgren
2012-09-18 19:24   ` a0919096
2012-09-18 19:24     ` a0919096
2012-09-19  9:57     ` Pantelis Antoniou
2012-09-19  9:57       ` Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120919172410.GF11762@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mporter@ti.com \
    --cc=panto@antoniou-consulting.com \
    --cc=shubhrajyoti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.