All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Duan, Ronghui" <ronghui.duan@intel.com>
Cc: "'xen-devel@lists.xen.org'" <xen-devel@lists.xen.org>,
	'Ian Jackson' <Ian.Jackson@eu.citrix.com>,
	'Jan Beulich' <JBeulich@suse.com>,
	'Stefano Stabellini' <stefano.stabellini@eu.citrix.com>
Subject: Re: [RFC v1 0/5] VBD: enlarge max segment per request in blkfront
Date: Wed, 19 Sep 2012 17:11:03 -0400	[thread overview]
Message-ID: <20120919211103.GA9488@phenom.dumpdata.com> (raw)
In-Reply-To: <A21691DE07B84740B5F0B81466D5148A23BF7E2F@SHSMSX102.ccr.corp.intel.com>

On Mon, Sep 17, 2012 at 06:33:29AM +0000, Duan, Ronghui wrote:
> At last, I saw the regression in random io.
> This is a patch to fix the performance regression. Original the pending request members are allocated from the stack, I alloc them when each request arrives in my last patch. But it will hurt performance. In this fix, I alloc all of them when blkback init. But due to some bugs there, we can't free it, the same to other pending requests member. I am looking for the reason. But have no idea for this now. 
> Konrad, thanks for your comments. Could you have a try when you have time.

Sure.  I get now:

  read : io=4096.0MB, bw=144258KB/s, iops=36064 , runt= 29075msec

so much better I/O.

> > > > > >> And with your patch got:
> > > > > >>   read : io=4096.0MB, bw=92606KB/s, iops=23151 , runt=
> > > > > >> 45292msec
> > > > > >>
> > > > > >> without:
> > > > > >>   read : io=4096.0MB, bw=145187KB/s, iops=36296 , runt=
> > > > > >> 28889msec

  parent reply	other threads:[~2012-09-19 21:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16 10:22 [RFC v1 0/5] VBD: enlarge max segment per request in blkfront Duan, Ronghui
2012-08-16 11:14 ` Jan Beulich
2012-08-17  1:12   ` Duan, Ronghui
2012-08-16 13:34 ` Konrad Rzeszutek Wilk
2012-08-16 13:55   ` Konrad Rzeszutek Wilk
2012-08-17  1:26     ` Duan, Ronghui
2012-08-16 14:18   ` Jan Beulich
2012-09-07 17:49 ` Konrad Rzeszutek Wilk
2012-09-13  2:28   ` Duan, Ronghui
2012-09-13  7:32     ` Jan Beulich
2012-09-13 11:05       ` Stefano Stabellini
2012-09-13 13:23         ` Konrad Rzeszutek Wilk
2012-09-13 14:05           ` Duan, Ronghui
2012-09-17  6:33             ` Duan, Ronghui
2012-09-17 14:37               ` Konrad Rzeszutek Wilk
2012-09-19 21:11               ` Konrad Rzeszutek Wilk [this message]
2012-09-13 13:21     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120919211103.GA9488@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=ronghui.duan@intel.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.