From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Eric Paris <eparis@redhat.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] audit: Use a tracepoint for getname
Date: Thu, 20 Sep 2012 09:10:08 +0200 [thread overview]
Message-ID: <20120920071008.GB2042@gmail.com> (raw)
In-Reply-To: <20120919225659.GA11325@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Al, Eric,
>
> Was this considered before? Acceptable?
>
> - Arnaldo
>
> ---
>
> Instead of an explicit hook only for audit, use a tracepoint, so that
> other users that need to know about filenames can hook there just like
> audit.
>
> Based on an earlier patch by Thomas Gleixner that added the tracepoint
> but left the audit_getname call.
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> fs/namei.c | 5 ++++-
> include/linux/audit.h | 6 +-----
> include/trace/events/vfs.h | 32 ++++++++++++++++++++++++++++++++
> init/Kconfig | 2 +-
> kernel/audit.c | 11 +++++++++++
> 5 files changed, 49 insertions(+), 7 deletions(-)
> create mode 100644 include/trace/events/vfs.h
Nice generalization and we gain a useful tracepoint as well.
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
next prev parent reply other threads:[~2012-09-20 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 22:56 [PATCH 1/1] audit: Use a tracepoint for getname Arnaldo Carvalho de Melo
2012-09-20 7:10 ` Ingo Molnar [this message]
2012-09-20 13:05 ` Eric Paris
2012-09-20 13:32 ` Steven Rostedt
2012-09-20 15:11 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920071008.GB2042@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eparis@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.