From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Assert that the exec object lookup table is a power-of-two Date: Thu, 20 Sep 2012 14:20:44 +0200 Message-ID: <20120920122044.GA11179@bremse> References: <1347959042-31590-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qc0-f177.google.com (mail-qc0-f177.google.com [209.85.216.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A1AD9E91D for ; Thu, 20 Sep 2012 05:20:54 -0700 (PDT) Received: by qcsu28 with SMTP id u28so1756662qcs.36 for ; Thu, 20 Sep 2012 05:20:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1347959042-31590-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Sep 18, 2012 at 10:04:02AM +0100, Chris Wilson wrote: > As we make the simplification of using a power-of-two size for the > execbuffer handle-to-object TLB, we should validate that this is actually > true and so clarify that premise. > > Signed-off-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > index 8186f63..6a2f3e5 100644 > --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > @@ -44,6 +44,7 @@ eb_create(int size) > { > struct eb_objects *eb; > int count = PAGE_SIZE / sizeof(struct hlist_head) / 2; > + BUILD_BUG_ON(!is_power_of_2(PAGE_SIZE / sizeof(struct hlist_head))); > while (count > size) > count >>= 1; > eb = kzalloc(count*sizeof(struct hlist_head) + > -- > 1.7.10.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch