From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [RESENDING] [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device Date: Thu, 20 Sep 2012 14:52:59 +0200 Message-ID: <20120920125259.GA2755@gmail.com> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-8-git-send-email-lee.jones@linaro.org> <20120919133343.GH25694@gmail.com> <505ADBE6.6080509@stericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id 65F98265315 for ; Thu, 20 Sep 2012 14:53:05 +0200 (CEST) Received: by eeke50 with SMTP id e50so818650eek.38 for ; Thu, 20 Sep 2012 05:53:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <505ADBE6.6080509@stericsson.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Ola Lilja Cc: "alsa-devel@alsa-project.org" , Linus WALLEIJ , "arnd@arndb.de" , "linus.walleij@linaro.org" , "broonie@opensource.wolfsonmicro.com" , "linux-kernel@vger.kernel.org" , STEricsson_nomadik_linux , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org PiA+IENhbiB3ZSBoYXZlIHNvbWUgY2xvc3VyZSBvbiB0aGlzIHBhdGNoIHBsZWFzZSwgYXMgaXQn cyBibG9ja2luZyB0aGUKPiA+IHBhdGNoLXNldD8gSSdtIGZhaXJseSBzdXJlIHRoZSBwYXRjaCBp cyBkb2luZyB0aGUgY29ycmVjdCB0aGluZywgYXMKPiA+IHNlY29uZGVkIGJ5IE1hcmsuCj4gCj4g SSBzdGlsbCBkb24ndCBsaWtlIHRoaXMuIEl0IGlzIHRoZSBkYWlfbGluay1zdHJ1Y3QgdGhhdCBi b3RoZXJzIG1lLiBXZSBoYXZlCj4gInV4NTAwLW1zcC1pMnMuMSIgYXMgbmFtZSBvZiB0aGUgcGxh dGZvcm0gQU5EIHRoZSBjcHVfZGFpLiBUaGUgTVNQIEkyUy1ibG9jayBpcwo+IG5vdCB0aGUgcGxh dGZvcm0gYW5kIGl0IGlzIGNlcnRhaW5seSBub3QgYm90aCBwbGF0Zm9ybSBhbmQgY3B1LURBSSBh dCB0aGUgc2FtZSB0aW1lLgo+IE1hcms6IERpZCB5b3UgaGF2ZSBhIHNvbHV0aW9uIGZvciB0aGlz PyBDb3VsZG4ndCB3ZSBqdXN0IHB1dCBOVUxMIG9uIHRoZQo+IHBsYXRmb3JtX25hbWUgaW5zdGVh ZD8KClRoZXJlIGFyZSBvdGhlciBkcml2ZXJzIHdoaWNoIGRvIHRoaXMgYWxyZWFkeS4gCgpJIGRv bid0IHRoaW5rIGl0J3MgYW4gaXNzdWUgdG8gZG8gdGhpcy4KCi0tIApMZWUgSm9uZXMKTGluYXJv IFNULUVyaWNzc29uIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNl IHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIg fCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFs c2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8v bWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 20 Sep 2012 14:52:59 +0200 Subject: [RESENDING] [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device In-Reply-To: <505ADBE6.6080509@stericsson.com> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-8-git-send-email-lee.jones@linaro.org> <20120919133343.GH25694@gmail.com> <505ADBE6.6080509@stericsson.com> Message-ID: <20120920125259.GA2755@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > Can we have some closure on this patch please, as it's blocking the > > patch-set? I'm fairly sure the patch is doing the correct thing, as > > seconded by Mark. > > I still don't like this. It is the dai_link-struct that bothers me. We have > "ux500-msp-i2s.1" as name of the platform AND the cpu_dai. The MSP I2S-block is > not the platform and it is certainly not both platform and cpu-DAI at the same time. > Mark: Did you have a solution for this? Couldn't we just put NULL on the > platform_name instead? There are other drivers which do this already. I don't think it's an issue to do this. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752185Ab2ITMxG (ORCPT ); Thu, 20 Sep 2012 08:53:06 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:36592 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035Ab2ITMxF (ORCPT ); Thu, 20 Sep 2012 08:53:05 -0400 Date: Thu, 20 Sep 2012 14:52:59 +0200 From: Lee Jones To: Ola Lilja Cc: "linus.walleij@linaro.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , Linus WALLEIJ , "arnd@arndb.de" , "broonie@opensource.wolfsonmicro.com" , STEricsson_nomadik_linux Subject: Re: [RESENDING] [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device Message-ID: <20120920125259.GA2755@gmail.com> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-8-git-send-email-lee.jones@linaro.org> <20120919133343.GH25694@gmail.com> <505ADBE6.6080509@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <505ADBE6.6080509@stericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Can we have some closure on this patch please, as it's blocking the > > patch-set? I'm fairly sure the patch is doing the correct thing, as > > seconded by Mark. > > I still don't like this. It is the dai_link-struct that bothers me. We have > "ux500-msp-i2s.1" as name of the platform AND the cpu_dai. The MSP I2S-block is > not the platform and it is certainly not both platform and cpu-DAI at the same time. > Mark: Did you have a solution for this? Couldn't we just put NULL on the > platform_name instead? There are other drivers which do this already. I don't think it's an issue to do this. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog