From: Samuel Ortiz <sameo@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not decla
Date: Thu, 20 Sep 2012 14:21:19 +0000 [thread overview]
Message-ID: <20120920142119.GR28670@sortiz-mobl> (raw)
In-Reply-To: <20120919233348.GD5607@localhost>
Hi Fengguang,
On Thu, Sep 20, 2012 at 07:33:48AM +0800, Fengguang Wu wrote:
> Hi Stephen,
>
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next
> head: 144c94c99ad2f20ff37ca77147a10da7718895ad
> commit: 9582fdcb6fcf1b596a83b161a2ea886272d2a62f [47/76] mfd: max8907: Add power off control
>
> All sparse warnings:
>
> + drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared. Should it be static?
>
> vim +179 drivers/mfd/max8907.c
> 169
> 170 static const struct regmap_irq_chip max8907_rtc_irq_chip = {
> 171 .name = "max8907 rtc",
> 172 .status_base = MAX8907_REG_RTC_IRQ,
> 173 .mask_base = MAX8907_REG_RTC_IRQ_MASK,
> 174 .num_regs = 1,
> 175 .irqs = max8907_rtc_irqs,
> 176 .num_irqs = ARRAY_SIZE(max8907_rtc_irqs),
> 177 };
> 178
> > 179 struct max8907 *max8907_pm_off;
> 180 static void max8907_power_off(void)
> 181 {
> 182 regmap_update_bits(max8907_pm_off->regmap_gen, MAX8907_REG_RESET_CNFG,
> 183 MAX8907_MASK_POWER_OFF, MAX8907_MASK_POWER_OFF);
> 184 }
> 185
> 186 static __devinit int max8907_i2c_probe(struct i2c_client *i2c,
> 187 const struct i2c_device_id *id)
> 188 {
> 189 struct max8907 *max8907;
>
> Please consider folding the attached diff :-)
I applied this one on top of my for-next branch. I took the freedom to add
your SOB on it, please let me know if that's an issue for you.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2012-09-20 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 23:33 [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared Fengguang Wu
2012-09-20 14:21 ` Samuel Ortiz [this message]
2012-09-20 15:48 ` [mfd:for-next 47/76] drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not decla Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920142119.GR28670@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.