From: Theodore Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Don't calc checksum in update_backups in online resize.
Date: Thu, 20 Sep 2012 11:54:49 -0400 [thread overview]
Message-ID: <20120920155449.GA14430@thunk.org> (raw)
In-Reply-To: <1348122823-4930-1-git-send-email-tm@tao.ma>
On Thu, Sep 20, 2012 at 02:33:43PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> update_backups is used to backup all the metadata blocks, so we should
> not take it for granted that 'data' is pointed to a super block and use
> ext4_superblock_csum_set to calculate the checksum there. In case
> the data is a group descriptor block, it will corrupt the last group
> descriptor. And e2fsck will complain it.
>
> As all the metadata checksum should already be OK when we do the backup,
> remove the wrong ext4_superblock_csum_set and it should be just fine.
>
> Reported-by: "Theodore Ts'o" <tytso@mit.edu>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Applied. Thanks for finding the fix!!
- Ted
prev parent reply other threads:[~2012-09-20 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 6:33 [PATCH] ext4: Don't calc checksum in update_backups in online resize Tao Ma
2012-09-20 15:54 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920155449.GA14430@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.