From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Jeff Layton <jlayton@redhat.com>
Cc: viro@zeniv.linux.org.uk, eparis@redhat.com,
linux-audit@redhat.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/10] vfs: define getname_info struct and have getname() return it
Date: Thu, 20 Sep 2012 09:44:48 -0700 [thread overview]
Message-ID: <20120920164448.GA19073@ghostprotocols.net> (raw)
In-Reply-To: <1348150999-13028-5-git-send-email-jlayton@redhat.com>
Em Thu, Sep 20, 2012 at 10:23:13AM -0400, Jeff Layton escreveu:
> getname() is intended to copy pathname strings from userspace into a
> kernel buffer. The result is just a string in kernel space. It would
> however be quite helpful to be able to attach some ancillary info to
> the string.
Tried with:
[acme@mica linux]$ git remote add viro git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal.git
[acme@mica linux]$ git checkout -b getname-signal-git viro/experimental-kernel_thread
[acme@mica linux]$ grep Subject /wb/getname/4.patch
Subject: [PATCH v2 04/10] vfs: define getname_info struct and have getname()
[acme@mica linux]$
[acme@mica linux]$ grep Subject /wb/getname/[1-3].patch
/wb/getname/1.patch:Subject: [PATCH v2 01/10] vfs: allocate page instead of names_cache buffer in
/wb/getname/2.patch:Subject: [PATCH v2 02/10] vfs: make dir_name arg to do_mount a const char *
/wb/getname/3.patch:Subject: [PATCH v2 03/10] acct: constify the name arg to acct_on
[acme@mica linux]$ git log --oneline | head -3
9e7ab47 acct: constify the name arg to acct_on
2c1cd21 vfs: make dir_name arg to do_mount a const char *
99080c0 vfs: allocate page instead of names_cache buffer in mount_block_root
[acme@mica linux]$
git am works for the first 3, then fails for the fourth, using patch I get:
[acme@mica linux]$ patch -p1 < /wb/getname/4.patch
<SNIP successfull part>
patching file fs/namei.c
Hunk #3 succeeded at 2124 (offset 4 lines).
Hunk #4 succeeded at 2144 (offset 4 lines).
Hunk #5 succeeded at 3070 (offset 4 lines).
Hunk #6 succeeded at 3279 (offset 4 lines).
Hunk #7 succeeded at 3374 (offset 4 lines).
Hunk #8 succeeded at 3465 (offset 4 lines).
Hunk #9 succeeded at 3478 (offset 4 lines).
Hunk #10 succeeded at 3760 (offset 4 lines).
Hunk #11 succeeded at 3998 (offset 4 lines).
patching file fs/namespace.c
patching file fs/open.c
patching file fs/quota/quota.c
patching file include/linux/audit.h
Hunk #1 succeeded at 451 with fuzz 2 (offset -8 lines).
Hunk #2 FAILED at 469.
Hunk #3 succeeded at 495 (offset -10 lines).
1 out of 3 hunks FAILED -- saving rejects to file include/linux/audit.h.rej
patching file include/linux/fs.h
patching file ipc/mqueue.c
Hunk #3 FAILED at 805.
Hunk #4 FAILED at 825.
2 out of 6 hunks FAILED -- saving rejects to file ipc/mqueue.c.rej
patching file kernel/acct.c
patching file kernel/auditsc.c
Hunk #1 FAILED at 103.
Hunk #2 succeeded at 1006 (offset 2 lines).
Hunk #3 succeeded at 1019 (offset 2 lines).
Hunk #4 succeeded at 1531 (offset 2 lines).
Hunk #5 succeeded at 1546 (offset 2 lines).
Hunk #7 FAILED at 2048.
Hunk #11 FAILED at 2166.
Hunk #12 FAILED at 2189.
Hunk #13 FAILED at 2230.
Hunk #14 FAILED at 2243.
Hunk #15 FAILED at 2277.
7 out of 15 hunks FAILED -- saving rejects to file kernel/auditsc.c.rej
patching file mm/swapfile.c
[acme@mica linux]$
next prev parent reply other threads:[~2012-09-20 16:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 14:23 [PATCH v2 00/10] vfs: getname/putname overhaul Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 01/10] vfs: allocate page instead of names_cache buffer in mount_block_root Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 02/10] vfs: make dir_name arg to do_mount a const char * Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 03/10] acct: constify the name arg to acct_on Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 04/10] vfs: define getname_info struct and have getname() return it Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 16:44 ` Arnaldo Carvalho de Melo [this message]
2012-09-20 17:00 ` Jeff Layton
2012-09-20 17:36 ` Arnaldo Carvalho de Melo
2012-09-20 17:41 ` Arnaldo Carvalho de Melo
2012-09-20 18:38 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 05/10] audit: allow audit code to satisfy getname requests from its names_list Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 06/10] vfs: turn do_path_lookup into wrapper around getname_info variant Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 07/10] vfs: make path_openat take a getname_info pointer Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 08/10] audit: make audit_inode take getname_info Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 09/10] vfs: embed getname_info inside of names_cache allocation if possible Jeff Layton
2012-09-20 14:23 ` Jeff Layton
2012-09-20 14:23 ` [PATCH v2 10/10] vfs: unexport getname and putname symbols Jeff Layton
2012-09-20 14:23 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920164448.GA19073@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=eparis@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.