All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Alex Dubov <oakad@yahoo.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memstick: add support for legacy memorysticks
Date: Thu, 20 Sep 2012 10:53:40 -0700	[thread overview]
Message-ID: <20120920175340.GE28934@google.com> (raw)
In-Reply-To: <1348113942.16096.18.camel@maxim-laptop>

On Thu, Sep 20, 2012 at 07:05:42AM +0300, Maxim Levitsky wrote:
> There can't be races in the driver, since it contains a single thread
> that does all the IO it got from block layer.
> The thread is awaken each time the request function of block device is
> called.
> This why I didn't do much locking in here. In addition I found out that
> this is quite common way to implement a block device driver.

Please use workqueue instead of raw kthread.

Thanks!

-- 
tejun

  reply	other threads:[~2012-09-20 17:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19 13:19 Maxim Levitsky
2012-09-19 13:19 ` [PATCH] memstick: add support for legacy memorysticks Maxim Levitsky
2012-09-19 21:52   ` Andrew Morton
2012-09-20  4:05     ` Maxim Levitsky
2012-09-20 17:53       ` Tejun Heo [this message]
2012-09-24 14:59         ` Maxim Levitsky
2012-09-24 15:09           ` Maxim Levitsky
2012-09-24 18:05             ` Tejun Heo
2012-09-24 18:19               ` Maxim Levitsky
2012-09-24 18:24                 ` Maxim Levitsky
2012-09-24 18:28                   ` Tejun Heo
2012-09-24 18:25                 ` Tejun Heo
2012-09-20 17:49     ` Tejun Heo
  -- strict thread matches above, loose matches on Subject: below --
2013-07-08 14:11 [merged] memstick-add-support-for-legacy-memorysticks.patch removed from -mm tree Maxim Levitsky
2013-07-08 20:54 ` Driver for memestick standard cards Maxim Levitsky
2013-07-08 20:54   ` [PATCH] memstick: add support for legacy memorysticks Maxim Levitsky
2013-07-11  0:28     ` Maxim Levitsky
2013-07-11 21:22       ` Andrew Morton
2013-07-17 20:35     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120920175340.GE28934@google.com \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maximlevitsky@gmail.com \
    --cc=oakad@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.