From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Paul Parsons <lost.distance@yahoo.com>
Cc: dwmw2@infradead.org, philipp.zabel@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pda_power: ac_draw used before set
Date: Thu, 20 Sep 2012 14:32:33 -0700 [thread overview]
Message-ID: <20120920213232.GA18223@lizard> (raw)
In-Reply-To: <505A0293.4070708@yahoo.com>
On Wed, Sep 19, 2012 at 06:36:19PM +0100, Paul Parsons wrote:
> When I reboot my iPAQ hx4700 in its cradle, the battery will not begin
> to charge even though the AC supply is connected. Charging will start
> only after the PDA power driver is tickled by some other power event,
> such as reseating the iPAQ in its cradle or connecting the USB cable.
>
> The problem lies in pda_power_probe(), where ac_draw is used by the call
> to update_charger() before being set by the call to regulator_get().
>
> Moving the regulator_get() call to before the update_charger() call
> fixes the problem.
>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> Cc: Philipp Zabel <philipp.zabel@gmail.com>
> ---
Great to see that someone is still using hx4700. :-)
Thanks for the patch, it is merged now!
Cheers,
Anton.
p.s.
The patch was mangled (word wrapped), but I fixed it up. Just fyi...
next prev parent reply other threads:[~2012-09-20 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 17:36 [PATCH] pda_power: ac_draw used before set Paul Parsons
2012-09-20 21:32 ` Anton Vorontsov [this message]
2012-09-21 0:16 ` Paul Parsons
2012-09-21 0:20 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920213232.GA18223@lizard \
--to=cbouatmailru@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.