From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Olof Johansson <olof@lixom.net>,
David Woodhouse <dwmw2@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sbs-battery: probe should try talking to the device
Date: Thu, 20 Sep 2012 14:59:27 -0700 [thread overview]
Message-ID: <20120920215926.GD18223@lizard> (raw)
In-Reply-To: <5048ECF2.8050307@nvidia.com>
On Thu, Sep 06, 2012 at 02:35:30PM -0400, Rhyland Klein wrote:
> On 09/06/2012 02:32 PM, Olof Johansson wrote:
> >Turns out this driver doesn't actually try talking to the device at
> >probe time, so if it's incorrectly configured in the device tree or
> >platform data (or if the battery has been removed from the system), then
> >probe will succeed and every access will sit there and time out. The
> >end result is a possibly laggy system that thinks it has a battery but
> >can never read status, which isn't very useful.
> >
> >Instead, just read any register (I chose status) at probe, and if that
> >fails, don't register the device.
> >
> >Signed-off-by: Olof Johansson <olof@lixom.net>
[...]
> Acked-by: Rhyland Klein <rklein@nvidia.com>
Applied, thank you folks!
prev parent reply other threads:[~2012-09-20 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 18:32 [PATCH] sbs-battery: probe should try talking to the device Olof Johansson
2012-09-06 18:35 ` Rhyland Klein
2012-09-20 21:59 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920215926.GD18223@lizard \
--to=cbouatmailru@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.