From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] power_supply: add new lp8788 charger driver
Date: Thu, 20 Sep 2012 15:16:38 -0700 [thread overview]
Message-ID: <20120920221638.GF18223@lizard> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F41EF2227@DQHE02.ent.ti.com>
On Wed, Sep 05, 2012 at 10:43:21AM +0000, Kim, Milo wrote:
> TI LP8788 PMU supports regulators, battery charger, RTC,
> ADC, backlight driver and current sinks.
>
> This patch supports the charger operations including
> the charger interrupt handling.
[...]
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
Had to fix a bunch of checkpatch complaints:
CHECK: space prohibited before semicolon
#478: FILE: drivers/power/lp8788-charger.c:396:
+ for (i = 0 ; i < pdata->num_chg_params ; i++) {
CHECK: space prohibited before semicolon
#541: FILE: drivers/power/lp8788-charger.c:459:
+ for (i = 0 ; i < pchg->num_irqs ; i++) {
But other than this, it looks really good, this is now applied.
Obviously, I couldn't compile-test it, but hopefully it will work
once MFD part is also in. :-) If not, you can just send a follow-up
fix.
Thanks!
next prev parent reply other threads:[~2012-09-20 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 10:43 [PATCH v4] power_supply: add new lp8788 charger driver Kim, Milo
2012-09-20 22:16 ` Anton Vorontsov [this message]
2012-09-20 23:19 ` Kim, Milo
2012-09-20 23:32 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920221638.GF18223@lizard \
--to=anton.vorontsov@linaro.org \
--cc=Milo.Kim@ti.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.