diff for duplicates of <20120920232408.GI13234@bbox> diff --git a/a/1.txt b/N1/1.txt index 6fc7a14..ea114d4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -75,3 +75,45 @@ On Thu, Sep 20, 2012 at 11:41:11AM -0400, Johannes Weiner wrote: > ? Good idea. Thanks Hannes, + +>From 13ae84083ac1f057eafbeae49efba862aa7a470e Mon Sep 17 00:00:00 2001 +From: Minchan Kim <minchan@kernel.org> +Date: Fri, 21 Sep 2012 08:17:37 +0900 +Subject: [PATCH] mm: enhance comment and bug check + +This patch updates comment and bug check. +It can be fold into [1]. + +[1] mm-revert-0def08e3-mm-mempolicyc-check-return-code-of-check_range.patch + +Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> +Suggested-by: Johannes Weiner <hannes@cmpxchg.org> +Signed-off-by: Minchan Kim <minchan@kernel.org> +--- + mm/mempolicy.c | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/mm/mempolicy.c b/mm/mempolicy.c +index 9ec87bd..0b78fb9 100644 +--- a/mm/mempolicy.c ++++ b/mm/mempolicy.c +@@ -951,9 +951,11 @@ static int migrate_to_node(struct mm_struct *mm, int source, int dest, + node_set(source, nmask); + + /* +- * Collect migrate pages and it shoudn't be failed. ++ * This does not "check" the range but isolates all pages that ++ * need migration. Between passing in the full user address ++ * space range and MPOL_MF_DISCONTIG_OK, this call can not fail. + */ +- VM_BUG_ON(flags & MPOL_MF_STRICT); ++ VM_BUG_ON(!(flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL))); + check_range(mm, mm->mmap->vm_start, mm->task_size, &nmask, + flags | MPOL_MF_DISCONTIG_OK, &pagelist); + +-- +1.7.9.5 + +-- +Kind regards, +Minchan Kim diff --git a/a/content_digest b/N1/content_digest index 70a2ee0..2177e6e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -88,6 +88,48 @@ "> \n" "> ?\n" "\n" - Good idea. Thanks Hannes, + "Good idea. Thanks Hannes,\n" + "\n" + ">From 13ae84083ac1f057eafbeae49efba862aa7a470e Mon Sep 17 00:00:00 2001\n" + "From: Minchan Kim <minchan@kernel.org>\n" + "Date: Fri, 21 Sep 2012 08:17:37 +0900\n" + "Subject: [PATCH] mm: enhance comment and bug check\n" + "\n" + "This patch updates comment and bug check.\n" + "It can be fold into [1].\n" + "\n" + "[1] mm-revert-0def08e3-mm-mempolicyc-check-return-code-of-check_range.patch\n" + "\n" + "Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>\n" + "Suggested-by: Johannes Weiner <hannes@cmpxchg.org>\n" + "Signed-off-by: Minchan Kim <minchan@kernel.org>\n" + "---\n" + " mm/mempolicy.c | 6 ++++--\n" + " 1 file changed, 4 insertions(+), 2 deletions(-)\n" + "\n" + "diff --git a/mm/mempolicy.c b/mm/mempolicy.c\n" + "index 9ec87bd..0b78fb9 100644\n" + "--- a/mm/mempolicy.c\n" + "+++ b/mm/mempolicy.c\n" + "@@ -951,9 +951,11 @@ static int migrate_to_node(struct mm_struct *mm, int source, int dest,\n" + " \tnode_set(source, nmask);\n" + " \n" + " \t/*\n" + "-\t * Collect migrate pages and it shoudn't be failed.\n" + "+\t * This does not \"check\" the range but isolates all pages that\n" + "+\t * need migration. Between passing in the full user address\n" + "+\t * space range and MPOL_MF_DISCONTIG_OK, this call can not fail.\n" + " \t */\n" + "-\tVM_BUG_ON(flags & MPOL_MF_STRICT);\n" + "+\tVM_BUG_ON(!(flags & (MPOL_MF_MOVE | MPOL_MF_MOVE_ALL)));\n" + " \tcheck_range(mm, mm->mmap->vm_start, mm->task_size, &nmask,\n" + " \t\t\tflags | MPOL_MF_DISCONTIG_OK, &pagelist);\n" + " \n" + "-- \n" + "1.7.9.5\n" + "\n" + "-- \n" + "Kind regards,\n" + Minchan Kim -b0538d747a252c15f03ee7980153372041fd7cc56a0e9ecb657b221b1f05f456 +d1aec1bbcacd61a2fefd6a65af1c4a5f65e7c799d541a780abd99666c0268851
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.