From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: jenny.tc@intel.com, ramakrishna.pallala@intel.com,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] charger-manager: Check fully charged state of battery periodically
Date: Thu, 20 Sep 2012 22:10:45 -0700 [thread overview]
Message-ID: <20120921051044.GB927@lizard> (raw)
In-Reply-To: <1345536412-25914-1-git-send-email-cw00.choi@samsung.com>
On Tue, Aug 21, 2012 at 05:06:52PM +0900, Chanwoo Choi wrote:
> This patch check periodically fully charged state of battery to protect
> overcharge and overheat. If battery is fully charged, stop charging
> and check droped voltage with 'fullbatt_vchkdrop_ms' period. When voltage
> of battery is more droped than 'fullbatt_vchkdrop_uV' voltage,
> charger-manager will restart charging for battery.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
Applied, thank you.
There were some minor issues, but I fixed them up:
[...]
> + } else if (!cm->emergency_stop
> + && is_ext_pwr_online(cm) && !cm->charger_enabled) {
Wrong && placement (should have been on the previous line).
> + fullbatt_vchk(&cm->fullbatt_vchk_work.work);
> +
> + /*
> + * Check whether fully charged state to protect overcharge
> + * if charger-manager is charging for battery.
> + */
> + } else if (!cm->emergency_stop
> + && is_full_charged(cm) && cm->charger_enabled) {
Ditto.
next prev parent reply other threads:[~2012-09-21 5:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 8:06 [PATCH 4/5] charger-manager: Check fully charged state of battery periodically Chanwoo Choi
2012-09-21 5:10 ` Anton Vorontsov [this message]
2012-09-21 7:18 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921051044.GB927@lizard \
--to=anton.vorontsov@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=jenny.tc@intel.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=ramakrishna.pallala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.