Re: [PATCH 1/5] phylib: bus reset function

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Sep 20, 2012 at 08:23:32PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:31 Thu 20 Sep     , Renaud Barbier wrote:
> > Added an entry point for a bus reset function.
> > 
> > Signed-off-by: Renaud Barbier <renaud.barbier@ge.com>
> > ---
> >  drivers/net/phy/phy.c |    3 +++
> >  include/miidev.h      |    1 +
> >  2 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> > index 5406ea3..d9f5409 100644
> > --- a/drivers/net/phy/phy.c
> > +++ b/drivers/net/phy/phy.c
> > @@ -129,6 +129,9 @@ int phy_device_connect(struct eth_device *edev, struct mii_device *bus, int addr
> >  	unsigned int i;
> >  	int ret = -EINVAL;
> >  
> > +	if (bus->reset)
> > +		bus->reset(bus);
> > +
> I do not like this we should not touch the bus at phy connect

Then please make a suggestion where it should be then. I also have some
drivers where this function could be used.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox