Re: [userns:userns-always-map-user-v58 86/150] fs/ncpfs/inode.c:335 ncp_show_options() warn: if();

[Fengguang Wu <fengguang.wu@intel.com>]

On Fri, Sep 21, 2012 at 11:44:58AM +0300, Dan Carpenter wrote:
> On Fri, Sep 21, 2012 at 04:40:05PM +0800, Fengguang Wu wrote:
> > On Fri, Sep 21, 2012 at 01:31:25AM -0700, Eric W. Biederman wrote:
> > > Fengguang Wu <fengguang.wu@intel.com> writes:
> > > 
> > > > Hi Eric,
> > > >
> > > > FYI, there are new smatch warnings show up in
> > > >
> > > > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git userns-always-map-user-v58
> > > > head:   cf7198a6b74906aa363a8507d6f9cbdf56e42dc1
> > > > commit: 84ec77ea8a96e568f20bec4465c1fbde2c066cf8 [86/150] userns: Convert ncpfs to use kuid and kgid where appropriate
> > > >
> > > > All smatch warnings:
> > > >
> > > > + fs/ncpfs/inode.c:335 ncp_show_options() warn: if();
> > > >   fs/ncpfs/inode.c:654 ncp_fill_super() Error invalid range 4096 to -1
> > > 
> > > Good catch.  Thanks.
> > > 
> > > Did you just start running smatch tests?  I haven't looked at ncpfs for
> > > a long time.
> > 
> > Yes. :)  I don't quite get the old "invalid range 4096 to -1" warning,
> > perhaps it's fine to just ignore it.
> > 
> 
> Yes, yes.  This shouldn't be there in the latest Smatch.  (I thought
> you were on that thread).  Let me know if it's still an issue.

The fix you suggested last time seem to be this, which I pulled and
installed promptly:

commit 72174b5c4bf53b830d71ae04d042722cdab3e1a2
Author:     Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Mon Sep 10 00:39:22 2012 +0300
Commit:     Dan Carpenter <dan.carpenter@oracle.com>
CommitDate: Mon Sep 10 00:39:22 2012 +0300

    check_kernel: fix ERR_PTR() false positives

    This was off and it was causing false positives like:
    net/mac80211/key.c:368 ieee80211_key_alloc() error: -4096 too low for ERR_PTR

Anyway I refreshed the smatch tree just now :)

Thanks,
Fengguang