From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33942)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TF0Ts-00073R-TY
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 06:29:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TF0Tk-0000V7-7t
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 06:29:08 -0400
Received: from hall.aurel32.net ([88.191.126.93]:41133)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TF0Tk-0000Uv-1i
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 06:29:00 -0400
Date: Fri, 21 Sep 2012 12:28:50 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20120921102850.GE4457@ohm.aurel32.net>
References: <CAAu8pHsgTnKcAhUaNB+feFJkioz=3gmewV+HDdRHTK1j+PDSZw@mail.gmail.com>
	<1347895732-22212-1-git-send-email-rth@twiddle.net>
	<1347895732-22212-14-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1347895732-22212-14-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 13/13] tcg: Fix !USE_DIRECT_JUMP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org

On Mon, Sep 17, 2012 at 08:28:52AM -0700, Richard Henderson wrote:
> Commit 6375e09e changed the type of TranslationBlock.tb_next,
> but failed to change the type of TCGContext.tb_next.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/tcg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tcg/tcg.h b/tcg/tcg.h
> index 7a72729..21016ec 100644
> --- a/tcg/tcg.h
> +++ b/tcg/tcg.h
> @@ -343,7 +343,7 @@ struct TCGContext {
>  
>      /* goto_tb support */
>      uint8_t *code_buf;
> -    unsigned long *tb_next;
> +    uintptr_t *tb_next;
>      uint16_t *tb_next_offset;
>      uint16_t *tb_jmp_offset; /* != NULL if USE_DIRECT_JUMP */
>  

Not directly sparc related, and definitely correct.

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net