From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Oliver Chick <oliver.chick@citrix.com>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Change xen_vbd's flush_support and discard_secure to have type unsigned int, rather than bool
Date: Fri, 21 Sep 2012 09:36:11 -0400 [thread overview]
Message-ID: <20120921133611.GD13227@phenom.dumpdata.com> (raw)
In-Reply-To: <1348218258-4418-1-git-send-email-oliver.chick@citrix.com>
On Fri, Sep 21, 2012 at 10:04:18AM +0100, Oliver Chick wrote:
> Changing the type of bdev parameters to be unsigned int :1, rather than bool.
> This is more consistent with the types of other features in the block drivers.
Thanks. Put in my for-jens branch.
>
> Signed-off-by: Oliver Chick <oliver.chick@citrix.com>
> ---
> drivers/block/xen-blkback/common.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkback/common.h
> index 9ad3b5e..9a54623 100644
> --- a/drivers/block/xen-blkback/common.h
> +++ b/drivers/block/xen-blkback/common.h
> @@ -158,8 +158,8 @@ struct xen_vbd {
> struct block_device *bdev;
> /* Cached size parameter. */
> sector_t size;
> - bool flush_support;
> - bool discard_secure;
> + unsigned int flush_support:1;
> + unsigned int discard_secure:1;
> };
>
> struct backend_info;
> --
> 1.7.9.5
prev parent reply other threads:[~2012-09-21 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 9:04 [PATCH] Change xen_vbd's flush_support and discard_secure to have type unsigned int, rather than bool Oliver Chick
2012-09-21 13:36 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921133611.GD13227@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.chick@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.