All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serge Hallyn <serge.hallyn@canonical.com>
To: Feng Hong <hongfeng@marvell.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"gorcunov@openvz.org" <gorcunov@openvz.org>,
	"keescook@chromium.org" <keescook@chromium.org>,
	"ebiederm@xmission.com" <ebiederm@xmission.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] poweroff: fix bug in orderly_poweroff
Date: Fri, 21 Sep 2012 10:30:33 -0500	[thread overview]
Message-ID: <20120921153033.GB13764@sergelap> (raw)
In-Reply-To: <E62404B31D39064FBDD0B843ADF05A7D2D395FCD2F@SC-VEXCH4.marvell.com>

Quoting Feng Hong (hongfeng@marvell.com):
> Hi, Serge,
> 
> I am just a graduate and it's my first time to send a patch to opensource, so thank you very much for reminding me the "changelog affairs", it seems this patch has been added to -mm tree as attached mail, and I have no chance to change the comments, right ? Then I must remember this and be careful next time. Thanks again for reminding me !

Sorry, your description was fine, what i meant was something below your
patch description that looks like

Change since v1:
	[date] Per Eric's sugestion, switch from UMH_WAIT_PROC to UMH_WAIT_EXEC.

> >Is this actually sufficient for you?  The exec will have started, but may for whatever (very unlikely) reason fail.  If you're happy with it,
> I think UMH_WAIT_EXEC is sufficient for me, as in our system there is no "/sbin/poweroff" existed. On the other hand, UMH_WAIT_PROC is not suitable here as Eric analysis; if using UMH_WAIT_EXEC, and the user application fail, I'd prefer to complain bad application. So using UMH_WAIT_EXEC and UMH_WAIT_PROC has a tradeoff here, what do you think so ?

Yup, that sounds fine to me, I just wanted to make sure you were ok with the
fact that application failure (after successful exec) will be ignored.

thanks,
-serge

  parent reply	other threads:[~2012-09-21 15:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-19  6:37 [PATCH V2] poweroff: fix bug in orderly_poweroff hongfeng
2012-09-20 17:06 ` Serge E. Hallyn
2012-09-21  0:16   ` Feng Hong
2012-09-21  0:25     ` Andrew Morton
2012-09-21  1:45       ` Feng Hong
2012-09-21 15:30     ` Serge Hallyn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-09-19  6:32 hongfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120921153033.GB13764@sergelap \
    --to=serge.hallyn@canonical.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=gorcunov@openvz.org \
    --cc=hongfeng@marvell.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.