From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3 05/16] consider a memcg parameter in kmem_create_cache Date: Fri, 21 Sep 2012 11:14:58 -0700 Message-ID: <20120921181458.GG7264@google.com> References: <1347977530-29755-1-git-send-email-glommer@parallels.com> <1347977530-29755-6-git-send-email-glommer@parallels.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=z8Ir4VcH4s5crFson/viq4+XlTxZsBLhdXd97gxHBlA=; b=AK78P8nnosToB59tGVdlUM5QOBgj4jGdOZmQpchbEkZEzpyeoBfCIl9Vbcw29kE7Pl 4tNlO8iTZ228H/WCgAsHDAUzrI6RFI6Ylc9NHeapRJLR0AsIOEanG6QW4sjArMooNxvo 0LiZgaGCy4my7DFUgUsT1NUt8P9eyQGg0co1rUfPtyFyWMio7EqfXt1DKbQNZTyGAw1Y XJRdEuuKgXBRI1WMSK6a/H2z16b1bfp39Ne9Kts2RzS39H7xMves6mA1yGskOul9B4uc KVHgTzQ3ZIXFN20YwL1M+aIWqm1OuRcF80SP1otb4J+gwD0v/fQ/X4PdtUDPfGv5tupo aIlQ== Content-Disposition: inline In-Reply-To: <1347977530-29755-6-git-send-email-glommer@parallels.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Glauber Costa Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, devel@openvz.org, linux-mm@kvack.org, Suleiman Souhlal , Frederic Weisbecker , Mel Gorman , David Rientjes , Christoph Lameter , Pekka Enberg , Michal Hocko , Johannes Weiner Hello, Glauber. On Tue, Sep 18, 2012 at 06:11:59PM +0400, Glauber Costa wrote: > +void memcg_register_cache(struct mem_cgroup *memcg, struct kmem_cache *cachep) > +{ > + int id = -1; > + > + if (!memcg) > + id = ida_simple_get(&cache_types, 0, MAX_KMEM_CACHE_TYPES, > + GFP_KERNEL); > + cachep->memcg_params.id = id; > +} I'm a bit confused. Why is id allocated only when memcg is NULL? Also, how would the per-memcg slab/slubs appear in slabinfo? If they appear separately it might be better to give them readable cgroup names. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757467Ab2IUSPK (ORCPT ); Fri, 21 Sep 2012 14:15:10 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:37407 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754948Ab2IUSPE (ORCPT ); Fri, 21 Sep 2012 14:15:04 -0400 Date: Fri, 21 Sep 2012 11:14:58 -0700 From: Tejun Heo To: Glauber Costa Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, devel@openvz.org, linux-mm@kvack.org, Suleiman Souhlal , Frederic Weisbecker , Mel Gorman , David Rientjes , Christoph Lameter , Pekka Enberg , Michal Hocko , Johannes Weiner Subject: Re: [PATCH v3 05/16] consider a memcg parameter in kmem_create_cache Message-ID: <20120921181458.GG7264@google.com> References: <1347977530-29755-1-git-send-email-glommer@parallels.com> <1347977530-29755-6-git-send-email-glommer@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1347977530-29755-6-git-send-email-glommer@parallels.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Glauber. On Tue, Sep 18, 2012 at 06:11:59PM +0400, Glauber Costa wrote: > +void memcg_register_cache(struct mem_cgroup *memcg, struct kmem_cache *cachep) > +{ > + int id = -1; > + > + if (!memcg) > + id = ida_simple_get(&cache_types, 0, MAX_KMEM_CACHE_TYPES, > + GFP_KERNEL); > + cachep->memcg_params.id = id; > +} I'm a bit confused. Why is id allocated only when memcg is NULL? Also, how would the per-memcg slab/slubs appear in slabinfo? If they appear separately it might be better to give them readable cgroup names. Thanks. -- tejun